Skip to content
This repository has been archived by the owner on Jul 6, 2021. It is now read-only.

notOk() assert #99

Closed
wants to merge 1 commit into from
Closed

notOk() assert #99

wants to merge 1 commit into from

Conversation

piranna
Copy link
Contributor

@piranna piranna commented Mar 1, 2015

This document the notOk() assert.]

@piranna piranna mentioned this pull request Mar 1, 2015
Closed
@leobalter
Copy link
Member

LGTM

@arthurvr
Copy link
Contributor

arthurvr commented Mar 2, 2015

Yup, LGTM! Thanks @piranna!

@piranna
Copy link
Contributor Author

piranna commented Mar 2, 2015

Yup, LGTM! Thanks @piranna!

You are welcome :-)

@leobalter
Copy link
Member

Waiting for the 1.18.0 release

@jzaefferer
Copy link
Member

You can merge this into a 1-18 branch. We can use that to gather all updates for 1.18 instead of keeping PRs open.

@arthurvr
Copy link
Contributor

arthurvr commented Apr 6, 2015

You can merge this into a 1-18 branch.

Is there a particular reason this PR is staying open or shall I go ahead and do that?

@jzaefferer
Copy link
Member

By now 1.18 is out, so this should land in master and get published. I forgot about it when I did the release.

@arthurvr
Copy link
Contributor

arthurvr commented Apr 6, 2015

haha, makes sense. Landing now.

@arthurvr arthurvr closed this in eee5583 Apr 6, 2015
@jzaefferer
Copy link
Member

Thanks. The tag should have been increased to 1.18.0 (minor, not patch). Not an actual problem, more for keeping track with actual QUnit changes.

@arthurvr
Copy link
Contributor

arthurvr commented Apr 6, 2015

Whoops! Sorry!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA: Valid
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@piranna @leobalter @arthurvr @jzaefferer @jquerybot