-
Notifications
You must be signed in to change notification settings - Fork 783
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Build: Update grunt-contrib-qunit to fix caching of Chromium binary
* Puppeteer stores the Chromium binary only in node_modules/ (not in $XDG_CACHE_HOME or some other directory that is generally persisted in dev and CI environments, nor in any other directory that one can opt-in to caching/persistence). This was fixed in Puppeteer 5+ (ref puppeteer/puppeteer#6014), through an opt-in PUPPETEER_DOWNLOAD_PATH env var. * I enalbed this in commit 7cd99a2, but it didn't do anything yet as grunt-contrib-qunit wasn't using the newer Puppeteer yet. This was fixed in gruntjs/grunt-contrib-qunit#173. * Fix ENV syntax. - Tildes aren't expanded in this context. - Other variables like $HOME aren't expanded either. - Absolute paths like /tmp can't be used because Windows runners interpret `/tmp` as `D:\tmp`, which doesn't exist by default, and Puppeteer requires the parent dir to exist instead of simply lazy-creating it. - Can't use a relative directory in the workspace like ".puppeteer" because Puppeteer insists on the variable being an absolute path. - We can use the `github.workspace` builtin variable, which we can subsitute per <https://git.io/JUJEE>.
- Loading branch information
Showing
6 changed files
with
39 additions
and
47 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters