CSS: Tweak CSS to address dropdown and button styles #1395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tested site can override the styling of buttons, which causes the displayed content to 'jump' around while tests are running, so ensure that all buttons in qunit elements are set to inital font size, border and background. With modules that have long names, the filter list becomes un-useable, so allow them to grow using min-width rather than fixed width
|
|
|
Seems like a nice improvement to me. |
trentmwillis
approved these changes
May 26, 2019
| [id^=qunit] button { | ||
| font-size: initial; | ||
| border: initial; | ||
| background-color: buttonface; |
There was a problem hiding this comment.
Was not familiar with this! Cool, TIL.
There was a problem hiding this comment.
this is an amazing color :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tested site can override the styling of buttons, which causes the
displayed content to 'jump' around while tests are running, so ensure
that all buttons in qunit elements are set to inital font size, border
and background.
With modules that have long names, the filter list becomes un-useable,
so allow them to grow using min-width rather than fixed width