add window.QUnit.reset() #1598
Closed
add window.QUnit.reset() #1598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hmm, isn't this adding a function named |
|
I thought reset is a better name because Im not calling Ive intentionally kept it this way because test modules need to be loaded/reevaluated before |
Krinkle
requested changes
Apr 28, 2021
There was a problem hiding this comment.
Thanks so much. I'm setting a negative score here for now to hold this back from my review queue while we continue at izelnakri/qunitx#2 (comment) (or elsewhere/here if you prefer).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds window.QUnit.reset() public API to make qunit state reset-able for future test suite restarts without page refreshes.
Relevant discussion: izelnakri/qunitx#2