Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code around ie issues for location #384

Closed
wants to merge 1 commit into from
Closed

code around ie issues for location #384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion qunit/qunit.js
View file
Open in desktop
Expand Up @@ -962,7 +962,8 @@ extend( QUnit, {
querystring += encodeURIComponent( key ) + "=" +
encodeURIComponent( params[ key ] ) + "&";
}
return window.location.pathname + querystring.slice( 0, -1 );
return window.location.protocol + "//" + window.location.host +
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry James M. Greene,

I didn't know force update removes comments associated with code segment. The
following is your original comment.

"That should definitely be window.location.host instead of
window.location.hostname. Also, I'm not sure if this works when using the
triple-slash short-form for File URIs on the localhost (i.e.
file://localhost/blah is equivalent to file:///blah) as I don't recall offhand
what the Location object will return for these properties when using the File
URI scheme...."

I just replaced hostname with host, you are right. :)

On the tripple-slash issue, I tried file:///* on Chrome, Firefox, IE7 and IE8.
They all work. I think it working. Maybe I don't understand your question?

window.location.pathname + querystring.slice( 0, -1 );
},

extend: extend,
Expand Down