Extract common IFF code to separate module. #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the AIFF and RIFF implementations to use the new IFF base classes.
|
Thanks! |
|
I'll create a release after #473 |
That'll be great. We want to do a Picard release soon, and having the WAVE support included would be fantastic :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the AIFF and RIFF implementations to use common IFF base classes. Both the AIFF and RIFF implementations share a lot of code. The differences between both implementations is that one uses big endian and the other little endian, also they obviously use different types of chunks.
The background for this is that I am also working on a DSDIFF (aka DFF) implementation. DSDIFF is also IFF based and thus again shares most of the code of the AIFF / RIFF implementations. The main difference to AIFF is that DSDIFF uses 8 bytes for the length instead of 4.
So I'm submitting this refactoring first and later the DSDIFF changes on top of this.