New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--play-file automatically adds file to the library #1537

Closed
lazka opened this Issue Mar 15, 2015 · 12 comments

Comments

Projects
None yet
1 participant
@lazka
Member

lazka commented Mar 15, 2015

Original issue 1537 created by marcelpaulo on 2015-02-11T14:36:13.000Z:

"quodlibet --play-file" automatically adds the file to the library. I would expect it not to add it, so that QL could be used to play singleton files from, for instance, a file manager — I want to use it to play files from Midnight Commander and mp3diags.

I experimented with different browsers, but the file is always added, even if the current browser is "FileSystem".

I'm running QL 3.3.1-0ppa0utopic on Xubuntu 14.10.

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #1 originally posted by reiter.christoph on 2015-02-11T14:46:26.000Z:

Thanks for the report. I agree.

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #2 originally posted by reiter.christoph on 2015-03-08T12:45:44.000Z:

This issue was closed by revision 0df908c.

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #3 originally posted by marcelpaulo on 2015-03-08T12:54:45.000Z:

Absolutely great, thank you so much, Christoph !

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #4 originally posted by marcelpaulo on 2015-03-09T08:01:01.000Z:

I've just installed QL 3.3.99+7452c016a77b5904-0ppa0~utopic (I'm tracking ppa:lazka/dumpingplace), and now --play-file doesn't seem to do anything, it just returns to the bash prompt without any action on the running QL instance.

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #5 originally posted by reiter.christoph on 2015-03-09T09:04:23.000Z:

<empty>

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #6 originally posted by reiter.christoph on 2015-03-09T09:06:05.000Z:

Did you restart QL after updating. I've changed some things that makes that necessary.

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #7 originally posted by marcelpaulo on 2015-03-09T09:13:29.000Z:

My sincerest apologies, Christoph, for wasting your time with such my trivial mistake: I hadn't restarted QL after the upgrade. --play-file indeed is not adding the song to the library anymore. Thanks for the fix !

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #8 originally posted by marcelpaulo on 2015-03-09T09:14:03.000Z:

My sincerest apologies, Christoph, for wasting your time with my silly mistake: I hadn't restarted QL after the upgrade. --play-file indeed is not adding the song to the library anymore. Thanks for the fix !

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #9 originally posted by reiter.christoph on 2015-03-09T09:19:03.000Z:

No problem. Thanks for the report.

btw: QL currently doesn't filter the browser to show the song passed with --play-file (e.g. switch to the right album in the album browser). Would you prefer that or the current behavior?

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #10 originally posted by marcelpaulo on 2015-03-09T09:23:47.000Z:

I think that the current behavior is perfect, since it doesn't touch the album/song which was previously playing, so that it can resume where it was interrupted by the --play-file song. Your solution seems excellent to me.

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #11 originally posted by reiter.christoph on 2015-03-09T09:32:47.000Z:

ok, thanks.

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #12 originally posted by reiter.christoph on 2015-03-09T09:32:56.000Z:

<empty>

@lazka lazka closed this Mar 15, 2015

lazka added a commit that referenced this issue Apr 7, 2015

--play-file: Don't add songs to the library. Closes issue #1537
Also remove the directory handling; it wasn't documented and hacky.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment