Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ReplayGain in mp4 #1916

Merged
merged 2 commits into from Apr 17, 2016
Merged

Support ReplayGain in mp4 #1916

merged 2 commits into from Apr 17, 2016

Conversation

@bp0
Copy link
Contributor

@bp0 bp0 commented Apr 16, 2016

Now QL and the QL ReplayGain Scanner will read and write ReplayGain tags from mp4/m4a files in the format used by the foobar2000 and deadbeef media players. There are no standard ReplayGain tags for mp4, it is simply the flac/vorbiscomment named tags and data format as mp4 freeform tags.

This is not support for Apple's "SoundCheck" iTunNorm tag.

Add support for mp4 ReplayGain tags in the format used by foobar2000 and deadbeef.
@lazka
Copy link
Member

@lazka lazka commented Apr 17, 2016

Please make sure ./setup.py quality passes.

Also tests would be nice, see tests/test_format_mp4.py

remove trailing whitespace; add test for replaygain tag support in mp4
@bp0 bp0 force-pushed the bp0:master branch from 29a0c33 to 6c16617 Apr 17, 2016
@bp0
Copy link
Contributor Author

@bp0 bp0 commented Apr 17, 2016

Now passes ./setup.py quality, although it passed locally even with those trailing spaces, so that is strange.
Added _assert_tag_supported() tests for each of the four tags.

@lazka lazka merged commit 70415a1 into quodlibet:master Apr 17, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lazka
Copy link
Member

@lazka lazka commented Apr 17, 2016

Thanks

@lazka
Copy link
Member

@lazka lazka commented Apr 17, 2016

Now passes ./setup.py quality, although it passed locally even with those trailing spaces, so that is strange.

Probably because pep8 or pyflakes wasn't installed and it skipped those tests. I've made it more strict now in c4d4f4d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants