Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix popup menu handling #2197

Merged
merged 4 commits into from
Jan 15, 2017
Merged

fix popup menu handling #2197

merged 4 commits into from
Jan 15, 2017

Conversation

darthoctopus
Copy link
Collaborator

@darthoctopus darthoctopus commented Jan 14, 2017

GtkIconView doesn't emit popup-menu events for right clicks but DOES when pressing the menu button on the keyboard. This should fix that use case.

@CreamyCookie
Copy link
Collaborator

CreamyCookie commented Jan 14, 2017

Thanks! Sadly, it doesn't seem to work.

Interesting note here from the docs on Gtk.Menu.popup which is used in covegrid/main.py to open the context menu:

Note that this function does not work very well on GDK backends that do not have global coordinates, such as Wayland or Mir. You should probably use one of the gtk_menu_popup_at_ variants, which do not have this problem.

Deprecated since version 3.22: Please use Gtk.Menu.popup_at_widget(), Gtk.Menu.popup_at_pointer(). or Gtk.Menu.popup_at_rect() instead

@CreamyCookie
Copy link
Collaborator

CreamyCookie commented Jan 14, 2017

@darthoctopus Gave the last change another try. Sadly still no context menu.

@lazka
Copy link
Member

lazka commented Jan 14, 2017

What about qltk.popup_menu_at_widget()?

@CreamyCookie
Copy link
Collaborator

@lazka Nice. That does work!

@CreamyCookie
Copy link
Collaborator

CreamyCookie commented Jan 14, 2017

Last change works! Thank you both!

@lazka lazka merged commit 2f6b784 into quodlibet:master Jan 15, 2017
@lazka
Copy link
Member

lazka commented Jan 15, 2017

thanks

lazka added a commit that referenced this pull request Jan 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants