Add skip by rating or tag #2201
Conversation
| (self._CFG_SKIP_BY_TAG, | ||
| _("Skip Songs with a Non-Empty 'skip' _Tag")), | ||
| ] | ||
| vb2 = Gtk.VBox(spacing=6) |
There was a problem hiding this comment.
Do I need vb2 along with vb here, or is that redundant? I copied this code from the duplicate songs plugin, but don't have the textbox above the checkboxes.
There was a problem hiding this comment.
I think you could just return the frame and get rid of vb, but how it is now makes it easier to extend in the future.
|
|
||
| def shouldSkip(self, playlist, song_iter): | ||
| song_index = playlist.get_path(song_iter).get_indices()[0] | ||
| song = playlist.get()[song_index] |
There was a problem hiding this comment.
Is there a nicer way to get the song object using the iterator? I looked here but I didn't see a better way.
There was a problem hiding this comment.
playlist.get_value(song_iter) should work (from qltk.models.ObjectStore)
|
Sorry for the delay, I'll have a look tomorrow. |
| (self._CFG_SKIP_BY_TAG, | ||
| _("Skip Songs with a Non-Empty 'skip' _Tag")), | ||
| ] | ||
| vb2 = Gtk.VBox(spacing=6) |
There was a problem hiding this comment.
I think you could just return the frame and get rid of vb, but how it is now makes it easier to extend in the future.
|
|
||
| return previous | ||
|
|
||
| def shouldSkip(self, playlist, song_iter): |
|
|
||
| def shouldSkip(self, playlist, song_iter): | ||
| song_index = playlist.get_path(song_iter).get_indices()[0] | ||
| song = playlist.get()[song_index] |
There was a problem hiding this comment.
playlist.get_value(song_iter) should work (from qltk.models.ObjectStore)
| def shouldSkip(self, playlist, song_iter): | ||
| song_index = playlist.get_path(song_iter).get_indices()[0] | ||
| song = playlist.get()[song_index] | ||
| rating = song("~#rating") |
There was a problem hiding this comment.
~#rating defaults to the default rating if it isn't set, you might also want to check song.has_rating in case the default is set to 0 by the user.
There was a problem hiding this comment.
Good idea; added a check for has_rating.
| song = playlist.get()[song_index] | ||
| rating = song("~#rating") | ||
|
|
||
| shouldSkip = False |
| if self.config_get_bool(self._CFG_SKIP_BY_RATING) and rating <= 0: | ||
| shouldSkip = True | ||
| print_d("Rating is %f; skipping..." % (rating)) | ||
| elif self.config_get_bool(self._CFG_SKIP_BY_TAG) and \ |
There was a problem hiding this comment.
FYI generally we prefer to use parentheses over multi-line expressions rather than \ at the end.
| shouldSkip = True | ||
| print_d("Rating is %f; skipping..." % (rating)) | ||
| elif self.config_get_bool(self._CFG_SKIP_BY_TAG) and \ | ||
| song("skip") != '': |
There was a problem hiding this comment.
and song("skip") is more Pythonic I'd say
There was a problem hiding this comment.
Removed comparison with '' and moved and to the next line.
|
Seems conceptually ok - but I'm still confused why users would want to add a |
Agreed, zero rating should be enough (or below threshold) |
For me, a rating of zero means "I don't even want this synchronized." A The other issue is that ratings do not save consistently to the actual files, while tags do. |
|
I've made the default to skip ratings of zero and ignore the |
|
I've made a few adjustments and pushed to master. |
|
@lazka Thanks for adding this. |
This adds a plugin that skips songs automatically if the rating is 0 or they have a non-empty
skiptag.I haven't done GTK in Python before, so there are two sections that I wonder if they could be done in a neater way; I'll add line comments for those.
Fixes #2161.