Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add composer to Wikipedia plugin #2862

Merged
merged 1 commit into from
May 26, 2018
Merged

Add composer to Wikipedia plugin #2862

merged 1 commit into from
May 26, 2018

Conversation

archy3
Copy link
Contributor

@archy3 archy3 commented May 22, 2018

This address #2861.

@frestr
Copy link
Member

frestr commented May 22, 2018

Hmm, it is perhaps a bit redundant to add a new plugin for this, especially when we already have the website search plugin which largely replaces the wikipedia plugin.

An alternative can be to add a submenu with tags to be searched, which can then be modified through the (wikipedia) plugin's preferences.

Just my two cents. I guess this can work for now though.

@lazka
Copy link
Member

lazka commented May 26, 2018

An alternative can be to add a submenu with tags to be searched, which can then be modified through the (wikipedia) plugin's preferences.

Agreed

Just my two cents. I guess this can work for now though.

yeah

@lazka lazka merged commit ae9a464 into quodlibet:master May 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants