-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor gettext code #3737
Merged
Merged
Refactor gettext code #3737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use `pathlib` paths everywhere. It's neater now and we get better checking * Add lots of typing, mypy does some work for us now * Use f-strings for great win * Fix some inappropriate test naming... * Improve some old / incorrect docstrings * Add some tests around `setup.py` PO commands (this broke them initially, but no tests broke)
For some reason other `.venv` is included (in Fedora...)
* Enforce user at Docker level not script * Exit on failure * Use same pytest options as other jobs
* Add steps in Github like other jobs
This reverts commit 503d405
This reverts commit 3285eaf
* Fedora - don't install ql into venv * Nicer debug on failure though
Seems I cannot build with that change. Is this maybe because of a missing dep?
|
declension
added a commit
that referenced
this pull request
Jul 12, 2021
this made paths in quodlibet.pot absolute somehow |
fixed in #3798 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pathlib
paths everywhere. It's neater now and we get better checkingsetup.py
PO commands (this broke them initially, but no tests broke)Fixes #3736