Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pre-commit.ci] pre-commit autoupdate #561

Closed
wants to merge 2 commits into from
Closed

[pre-commit.ci] pre-commit autoupdate #561

wants to merge 2 commits into from

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Mar 12, 2024 •
edited

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 12, 2024
View reviewed changes
src/EOS.hpp
const std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> massScalars)
-> amrex::Real
AMREX_FORCE_INLINE AMREX_GPU_HOST_DEVICE auto
EOS<problem_t>::ComputeEintFromTgas(amrex::Real rho, amrex::Real Tgas, const std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> massScalars) -> amrex::Real

Check notice

Code scanning / CodeQL

Large object passed by value Note

This parameter of type
optional<GpuArray<double, 14U>>
is 120 bytes - consider passing a const pointer/reference instead.
src/EOS.hpp
const std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> massScalars)
-> amrex::Real
AMREX_FORCE_INLINE AMREX_GPU_HOST_DEVICE auto
EOS<problem_t>::ComputeTgasFromEint(amrex::Real rho, amrex::Real Eint, const std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> massScalars) -> amrex::Real

Check notice

Code scanning / CodeQL

Large object passed by value Note

This parameter of type
optional<GpuArray<double, 14U>>
is 120 bytes - consider passing a const pointer/reference instead.
src/EOS.hpp
-> amrex::Real
AMREX_FORCE_INLINE AMREX_GPU_HOST_DEVICE auto
EOS<problem_t>::ComputeEintFromPres(amrex::Real rho, amrex::Real Pressure,
const std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> massScalars) -> amrex::Real

Check notice

Code scanning / CodeQL

Large object passed by value Note

This parameter of type
optional<GpuArray<double, 14U>>
is 120 bytes - consider passing a const pointer/reference instead.
src/EOS.hpp
const std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> massScalars)
-> amrex::Real
AMREX_FORCE_INLINE AMREX_GPU_HOST_DEVICE auto
EOS<problem_t>::ComputePressure(amrex::Real rho, amrex::Real Eint, const std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> massScalars) -> amrex::Real

Check notice

Code scanning / CodeQL

Large object passed by value Note

This parameter of type
optional<GpuArray<double, 14U>>
is 120 bytes - consider passing a const pointer/reference instead.
src/EOS.hpp
-> amrex::Real
AMREX_FORCE_INLINE AMREX_GPU_HOST_DEVICE auto
EOS<problem_t>::ComputeSoundSpeed(amrex::Real rho, amrex::Real Pressure,
const std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> massScalars) -> amrex::Real

Check notice

Code scanning / CodeQL

Large object passed by value Note

This parameter of type
optional<GpuArray<double, 14U>>
is 120 bytes - consider passing a const pointer/reference instead.
@BenWibking
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 5 pipeline(s).

@BenWibking
Copy link
Collaborator

BenWibking commented Mar 23, 2024 •
edited

clang-tidy warnings:

{'DiagnosticName': 'misc-unused-parameters', 'DiagnosticMessage': {'Message': "parameter 'massScalars' is unused", 'FilePath': '/github/workspace/src/EOS.hpp', 'FileOffset': 3148, 'Replacements': [{'FilePath': '/github/workspace/src/EOS.hpp', 'Offset': 3148, 'Length': 11, 'ReplacementText': ' /*massScalars*/'}]}, 'Level': 'Warning', 'BuildDirectory': '/github/workspace/build/src/Advection'}, 
{'DiagnosticName': 'misc-unused-parameters', 'DiagnosticMessage': {'Message': "parameter 'massScalars' is unused", 'FilePath': '/github/workspace/src/EOS.hpp', 'FileOffset': 4297, 'Replacements': [{'FilePath': '/github/workspace/src/EOS.hpp', 'Offset': 4297, 'Length': 11, 'ReplacementText': ' /*massScalars*/'}]}, 'Level': 'Warning', 'BuildDirectory': '/github/workspace/build/src/Advection'}, 
{'DiagnosticName': 'misc-unused-parameters', 'DiagnosticMessage': {'Message': "parameter 'massScalars' is unused", 'FilePath': '/github/workspace/src/EOS.hpp', 'FileOffset': 5463, 'Replacements': [{'FilePath': '/github/workspace/src/EOS.hpp', 'Offset': 5463, 'Length': 11, 'ReplacementText': ' /*massScalars*/'}]}, 'Level': 'Warning', 'BuildDirectory': '/github/workspace/build/src/Advection'}, 
{'DiagnosticName': 'misc-unused-parameters', 'DiagnosticMessage': {'Message': "parameter 'massScalars' is unused", 'FilePath': '/github/workspace/src/EOS.hpp', 'FileOffset': 9675, 'Replacements': [{'FilePath': '/github/workspace/src/EOS.hpp', 'Offset': 9675, 'Length': 11, 'ReplacementText': ' /*massScalars*/'}]}, 'Level': 'Warning', 'BuildDirectory': '/github/workspace/build/src/Advection'}, 
{'DiagnosticName': 'misc-unused-parameters', 'DiagnosticMessage': {'Message': "parameter 'massScalars' is unused", 'FilePath': '/github/workspace/src/EOS.hpp', 'FileOffset': 10764, 'Replacements': [{'FilePath': '/github/workspace/src/EOS.hpp', 'Offset': 10764, 'Length': 11, 'ReplacementText': ' /*massScalars*/'}]}, 'Level': 'Warning', 'BuildDirectory': '/github/workspace/build/src/Advection'}, 
{'DiagnosticName': 'misc-unused-parameters', 'DiagnosticMessage': {'Message': "parameter 'rho' is unused", 'FilePath': '/github/workspace/src/RadMarshakCGS/test_radiation_marshak_cgs.cpp', 'FileOffset': 3084, 'Replacements': [{'FilePath': '/github/workspace/src/RadMarshakCGS/test_radiation_marshak_cgs.cpp', 'Offset': 3084, 'Length': 1, 'ReplacementText': ' /*rho*/'}]}, 'Level': 'Warning', 'BuildDirectory': '/github/workspace/build/src/RadMarshakCGS'}, 
{'DiagnosticName': 'misc-unused-parameters', 'DiagnosticMessage': {'Message': "parameter 'massScalars' is unused", 'FilePath': '/github/workspace/src/RadMarshakCGS/test_radiation_marshak_cgs.cpp', 'FileOffset': 3186, 'Replacements': [{'FilePath': '/github/workspace/src/RadMarshakCGS/test_radiation_marshak_cgs.cpp', 'Offset': 3186, 'Length': 1, 'ReplacementText': ' /*massScalars*/'}]}, 'Level': 'Warning', 'BuildDirectory': '/github/workspace/build/src/RadMarshakCGS'}, 
{'DiagnosticName': 'misc-unused-parameters', 'DiagnosticMessage': {'Message': "parameter 'rho' is unused", 'FilePath': '/github/workspace/src/RadMarshakCGS/test_radiation_marshak_cgs.cpp', 'FileOffset': 3369, 'Replacements': [{'FilePath': '/github/workspace/src/RadMarshakCGS/test_radiation_marshak_cgs.cpp', 'Offset': 3369, 'Length': 1, 'ReplacementText': ' /*rho*/'}]}, 'Level': 'Warning', 'BuildDirectory': '/github/workspace/build/src/RadMarshakCGS'}, 
{'DiagnosticName': 'misc-unused-parameters', 'DiagnosticMessage': {'Message': "parameter 'massScalars' is unused", 'FilePath': '/github/workspace/src/RadMarshakCGS/test_radiation_marshak_cgs.cpp', 'FileOffset': 3471, 'Replacements': [{'FilePath': '/github/workspace/src/RadMarshakCGS/test_radiation_marshak_cgs.cpp', 'Offset': 3471, 'Length': 1, 'ReplacementText': ' /*massScalars*/'}]}, 'Level': 'Warning', 'BuildDirectory': '/github/workspace/build/src/RadMarshakCGS'}, 
{'DiagnosticName': 'misc-unused-parameters', 'DiagnosticMessage': {'Message': "parameter 'massScalars' is unused", 'FilePath': '/github/workspace/src/RadTophat/test_radiation_tophat.cpp', 'FileOffset': 3827, 'Replacements': [{'FilePath': '/github/workspace/src/RadTophat/test_radiation_tophat.cpp', 'Offset': 3827, 'Length': 1, 'ReplacementText': ' /*massScalars*/'}]}, 'Level': 'Warning', 'BuildDirectory': '/github/workspace/build/src/RadTophat'}]}

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from a5a767a to dfb6260 Compare March 25, 2024 17:06
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from b102ffc to b3187fd Compare April 8, 2024 17:13
github-actions[bot]
github-actions bot reviewed Apr 8, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/EOS.hpp
const std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> massScalars)
-> amrex::Real
AMREX_FORCE_INLINE AMREX_GPU_HOST_DEVICE auto
EOS<problem_t>::ComputeTgasFromEint(amrex::Real rho, amrex::Real Eint, const std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> massScalars) -> amrex::Real
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: parameter 'massScalars' is unused [misc-unused-parameters]

Suggested change
EOS<problem_t>::ComputeTgasFromEint(amrex::Real rho, amrex::Real Eint, const std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> massScalars) -> amrex::Real
EOS<problem_t>::ComputeTgasFromEint(amrex::Real rho, amrex::Real Eint, const std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> /*massScalars*/) -> amrex::Real

src/EOS.hpp
const std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> massScalars)
-> amrex::Real
AMREX_FORCE_INLINE AMREX_GPU_HOST_DEVICE auto
EOS<problem_t>::ComputeEintFromTgas(amrex::Real rho, amrex::Real Tgas, const std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> massScalars) -> amrex::Real
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: parameter 'massScalars' is unused [misc-unused-parameters]

Suggested change
EOS<problem_t>::ComputeEintFromTgas(amrex::Real rho, amrex::Real Tgas, const std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> massScalars) -> amrex::Real
EOS<problem_t>::ComputeEintFromTgas(amrex::Real rho, amrex::Real Tgas, const std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> /*massScalars*/) -> amrex::Real

src/EOS.hpp
-> amrex::Real
AMREX_FORCE_INLINE AMREX_GPU_HOST_DEVICE auto
EOS<problem_t>::ComputeEintFromPres(amrex::Real rho, amrex::Real Pressure,
const std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> massScalars) -> amrex::Real
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: parameter 'massScalars' is unused [misc-unused-parameters]

Suggested change
const std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> massScalars) -> amrex::Real
const std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> /*massScalars*/) -> amrex::Real

src/EOS.hpp
const std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> massScalars)
-> amrex::Real
AMREX_FORCE_INLINE AMREX_GPU_HOST_DEVICE auto
EOS<problem_t>::ComputePressure(amrex::Real rho, amrex::Real Eint, const std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> massScalars) -> amrex::Real
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: parameter 'massScalars' is unused [misc-unused-parameters]

Suggested change
EOS<problem_t>::ComputePressure(amrex::Real rho, amrex::Real Eint, const std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> massScalars) -> amrex::Real
EOS<problem_t>::ComputePressure(amrex::Real rho, amrex::Real Eint, const std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> /*massScalars*/) -> amrex::Real

src/EOS.hpp
-> amrex::Real
AMREX_FORCE_INLINE AMREX_GPU_HOST_DEVICE auto
EOS<problem_t>::ComputeSoundSpeed(amrex::Real rho, amrex::Real Pressure,
const std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> massScalars) -> amrex::Real
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: parameter 'massScalars' is unused [misc-unused-parameters]

Suggested change
const std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> massScalars) -> amrex::Real
const std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> /*massScalars*/) -> amrex::Real

src/RadMarshakCGS/test_radiation_marshak_cgs.cpp
std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> /*massScalars*/)
-> double
AMREX_GPU_HOST_DEVICE auto
quokka::EOS<SuOlsonProblemCgs>::ComputeTgasFromEint(const double /*rho*/, const double Egas,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: parameter 'rho' is unused [misc-unused-parameters]

Suggested change
quokka::EOS<SuOlsonProblemCgs>::ComputeTgasFromEint(const double /*rho*/, const double Egas,
quokka::EOS<SuOlsonProblemCgs>::ComputeTgasFromEint(const double /*rho*/ /*rho*/ const double Egas,

src/RadMarshakCGS/test_radiation_marshak_cgs.cpp
-> double
AMREX_GPU_HOST_DEVICE auto
quokka::EOS<SuOlsonProblemCgs>::ComputeTgasFromEint(const double /*rho*/, const double Egas,
std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> /*massScalars*/) -> double
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: parameter 'massScalars' is unused [misc-unused-parameters]

Suggested change
std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> /*massScalars*/) -> double
std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> /*massScalars*/ /*massScalars*/ -> double

src/RadMarshakCGS/test_radiation_marshak_cgs.cpp
std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> /*massScalars*/)
-> double
AMREX_GPU_HOST_DEVICE auto
quokka::EOS<SuOlsonProblemCgs>::ComputeEintFromTgas(const double /*rho*/, const double Tgas,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: parameter 'rho' is unused [misc-unused-parameters]

Suggested change
quokka::EOS<SuOlsonProblemCgs>::ComputeEintFromTgas(const double /*rho*/, const double Tgas,
quokka::EOS<SuOlsonProblemCgs>::ComputeEintFromTgas(const double /*rho*/ /*rho*/ const double Tgas,

src/RadMarshakCGS/test_radiation_marshak_cgs.cpp
-> double
AMREX_GPU_HOST_DEVICE auto
quokka::EOS<SuOlsonProblemCgs>::ComputeEintFromTgas(const double /*rho*/, const double Tgas,
std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> /*massScalars*/) -> double
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: parameter 'massScalars' is unused [misc-unused-parameters]

Suggested change
std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> /*massScalars*/) -> double
std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> /*massScalars*/ /*massScalars*/ -> double

src/RadTophat/test_radiation_tophat.cpp
quokka::EOS<TophatProblem>::ComputeEintFromTgas(const double rho, const double Tgas, std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> /*massScalars*/)
-> double
quokka::EOS<TophatProblem>::ComputeEintFromTgas(const double rho, const double Tgas,
std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> /*massScalars*/) -> double
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: parameter 'massScalars' is unused [misc-unused-parameters]

Suggested change
std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> /*massScalars*/) -> double
std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> /*massScalars*/ /*massScalars*/ -> double

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from b35e24b to 181f0ef Compare April 22, 2024 17:04
@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate
6bebb95 
updates:
- [github.com/pre-commit/pre-commit-hooks: v4.5.0 → v4.6.0](pre-commit/pre-commit-hooks@v4.5.0...v4.6.0)
- [github.com/pre-commit/mirrors-clang-format: v17.0.6 → v18.1.5](pre-commit/mirrors-clang-format@v17.0.6...v18.1.5)
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 181f0ef to 6bebb95 Compare May 13, 2024 17:04
@BenWibking BenWibking closed this Jun 10, 2024
@BenWibking BenWibking deleted the pre-commit-ci-update-config branch June 10, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@BenWibking