-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pre-commit.ci] pre-commit autoupdate #561
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -68,9 +68,8 @@ | |||||
}; | ||||||
|
||||||
template <typename problem_t> | ||||||
AMREX_FORCE_INLINE AMREX_GPU_HOST_DEVICE auto EOS<problem_t>::ComputeTgasFromEint(amrex::Real rho, amrex::Real Eint, | ||||||
const std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> massScalars) | ||||||
-> amrex::Real | ||||||
AMREX_FORCE_INLINE AMREX_GPU_HOST_DEVICE auto | ||||||
EOS<problem_t>::ComputeTgasFromEint(amrex::Real rho, amrex::Real Eint, const std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> massScalars) -> amrex::Real | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. warning: parameter 'massScalars' is unused [misc-unused-parameters]
Suggested change
|
||||||
{ | ||||||
// return temperature for an ideal gas given density and internal energy | ||||||
amrex::Real Tgas = NAN; | ||||||
|
@@ -108,9 +107,8 @@ | |||||
} | ||||||
|
||||||
template <typename problem_t> | ||||||
AMREX_FORCE_INLINE AMREX_GPU_HOST_DEVICE auto EOS<problem_t>::ComputeEintFromTgas(amrex::Real rho, amrex::Real Tgas, | ||||||
const std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> massScalars) | ||||||
-> amrex::Real | ||||||
AMREX_FORCE_INLINE AMREX_GPU_HOST_DEVICE auto | ||||||
EOS<problem_t>::ComputeEintFromTgas(amrex::Real rho, amrex::Real Tgas, const std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> massScalars) -> amrex::Real | ||||||
Check notice Code scanning / CodeQL Large object passed by value Note
This parameter of type
optional<GpuArray<double, 14U>> Error loading related location Loading There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. warning: parameter 'massScalars' is unused [misc-unused-parameters]
Suggested change
|
||||||
{ | ||||||
// return internal energy density given density and temperature | ||||||
amrex::Real Eint = NAN; | ||||||
|
@@ -149,9 +147,9 @@ | |||||
} | ||||||
|
||||||
template <typename problem_t> | ||||||
AMREX_FORCE_INLINE AMREX_GPU_HOST_DEVICE auto EOS<problem_t>::ComputeEintFromPres(amrex::Real rho, amrex::Real Pressure, | ||||||
const std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> massScalars) | ||||||
-> amrex::Real | ||||||
AMREX_FORCE_INLINE AMREX_GPU_HOST_DEVICE auto | ||||||
EOS<problem_t>::ComputeEintFromPres(amrex::Real rho, amrex::Real Pressure, | ||||||
const std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> massScalars) -> amrex::Real | ||||||
Check notice Code scanning / CodeQL Large object passed by value Note
This parameter of type
optional<GpuArray<double, 14U>> Error loading related location Loading There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. warning: parameter 'massScalars' is unused [misc-unused-parameters]
Suggested change
|
||||||
{ | ||||||
// return internal energy density given density and pressure | ||||||
amrex::Real Eint = NAN; | ||||||
|
@@ -283,9 +281,8 @@ | |||||
} | ||||||
|
||||||
template <typename problem_t> | ||||||
AMREX_FORCE_INLINE AMREX_GPU_HOST_DEVICE auto EOS<problem_t>::ComputePressure(amrex::Real rho, amrex::Real Eint, | ||||||
const std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> massScalars) | ||||||
-> amrex::Real | ||||||
AMREX_FORCE_INLINE AMREX_GPU_HOST_DEVICE auto | ||||||
EOS<problem_t>::ComputePressure(amrex::Real rho, amrex::Real Eint, const std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> massScalars) -> amrex::Real | ||||||
Check notice Code scanning / CodeQL Large object passed by value Note
This parameter of type
optional<GpuArray<double, 14U>> Error loading related location Loading There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. warning: parameter 'massScalars' is unused [misc-unused-parameters]
Suggested change
|
||||||
{ | ||||||
// return pressure for an ideal gas | ||||||
amrex::Real P = NAN; | ||||||
|
@@ -326,9 +323,9 @@ | |||||
} | ||||||
|
||||||
template <typename problem_t> | ||||||
AMREX_FORCE_INLINE AMREX_GPU_HOST_DEVICE auto EOS<problem_t>::ComputeSoundSpeed(amrex::Real rho, amrex::Real Pressure, | ||||||
const std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> massScalars) | ||||||
-> amrex::Real | ||||||
AMREX_FORCE_INLINE AMREX_GPU_HOST_DEVICE auto | ||||||
EOS<problem_t>::ComputeSoundSpeed(amrex::Real rho, amrex::Real Pressure, | ||||||
const std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> massScalars) -> amrex::Real | ||||||
Check notice Code scanning / CodeQL Large object passed by value Note
This parameter of type
optional<GpuArray<double, 14U>> Error loading related location Loading There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. warning: parameter 'massScalars' is unused [misc-unused-parameters]
Suggested change
|
||||||
{ | ||||||
// return sound speed for an ideal gas | ||||||
amrex::Real cs = NAN; | ||||||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -68,33 +68,33 @@ AMREX_GPU_HOST_DEVICE auto RadSystem<SuOlsonProblemCgs>::ComputePlanckOpacity(co | |||||
} | ||||||
|
||||||
template <> | ||||||
AMREX_GPU_HOST_DEVICE auto RadSystem<SuOlsonProblemCgs>::ComputeFluxMeanOpacity(const double /*rho*/, const double /*Tgas*/) | ||||||
-> quokka::valarray<double, nGroups_> | ||||||
AMREX_GPU_HOST_DEVICE auto RadSystem<SuOlsonProblemCgs>::ComputeFluxMeanOpacity(const double /*rho*/, | ||||||
const double /*Tgas*/) -> quokka::valarray<double, nGroups_> | ||||||
{ | ||||||
return ComputePlanckOpacity(0.0, 0.0); | ||||||
} | ||||||
|
||||||
static constexpr int nmscalars_ = Physics_Traits<SuOlsonProblemCgs>::numMassScalars; | ||||||
template <> | ||||||
AMREX_GPU_HOST_DEVICE auto quokka::EOS<SuOlsonProblemCgs>::ComputeTgasFromEint(const double /*rho*/, const double Egas, | ||||||
std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> /*massScalars*/) | ||||||
-> double | ||||||
AMREX_GPU_HOST_DEVICE auto | ||||||
quokka::EOS<SuOlsonProblemCgs>::ComputeTgasFromEint(const double /*rho*/, const double Egas, | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. warning: parameter 'rho' is unused [misc-unused-parameters]
Suggested change
|
||||||
std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> /*massScalars*/) -> double | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. warning: parameter 'massScalars' is unused [misc-unused-parameters]
Suggested change
|
||||||
{ | ||||||
return std::pow(4.0 * Egas / alpha_SuOlson, 1. / 4.); | ||||||
} | ||||||
|
||||||
template <> | ||||||
AMREX_GPU_HOST_DEVICE auto quokka::EOS<SuOlsonProblemCgs>::ComputeEintFromTgas(const double /*rho*/, const double Tgas, | ||||||
std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> /*massScalars*/) | ||||||
-> double | ||||||
AMREX_GPU_HOST_DEVICE auto | ||||||
quokka::EOS<SuOlsonProblemCgs>::ComputeEintFromTgas(const double /*rho*/, const double Tgas, | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. warning: parameter 'rho' is unused [misc-unused-parameters]
Suggested change
|
||||||
std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> /*massScalars*/) -> double | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. warning: parameter 'massScalars' is unused [misc-unused-parameters]
Suggested change
|
||||||
{ | ||||||
return (alpha_SuOlson / 4.0) * std::pow(Tgas, 4); | ||||||
} | ||||||
|
||||||
template <> | ||||||
AMREX_GPU_HOST_DEVICE auto quokka::EOS<SuOlsonProblemCgs>::ComputeEintTempDerivative(const double /*rho*/, const double Tgas, | ||||||
std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> /*massScalars*/) | ||||||
-> double | ||||||
AMREX_GPU_HOST_DEVICE auto | ||||||
quokka::EOS<SuOlsonProblemCgs>::ComputeEintTempDerivative(const double /*rho*/, const double Tgas, | ||||||
std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> /*massScalars*/) -> double | ||||||
{ | ||||||
// This is also known as the heat capacity, i.e. | ||||||
// \del E_g / \del T = \rho c_v, | ||||||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -60,8 +60,8 @@ template <> struct Physics_Traits<TophatProblem> { | |||||
}; | ||||||
|
||||||
template <> | ||||||
AMREX_FORCE_INLINE AMREX_GPU_HOST_DEVICE auto RadSystem<TophatProblem>::ComputePlanckOpacity(const double rho, const double /*Tgas*/) | ||||||
-> quokka::valarray<double, nGroups_> | ||||||
AMREX_FORCE_INLINE AMREX_GPU_HOST_DEVICE auto RadSystem<TophatProblem>::ComputePlanckOpacity(const double rho, | ||||||
const double /*Tgas*/) -> quokka::valarray<double, nGroups_> | ||||||
{ | ||||||
quokka::valarray<double, nGroups_> kappaPVec{}; | ||||||
amrex::Real kappa = 0.; | ||||||
|
@@ -77,25 +77,25 @@ AMREX_FORCE_INLINE AMREX_GPU_HOST_DEVICE auto RadSystem<TophatProblem>::ComputeP | |||||
} | ||||||
|
||||||
template <> | ||||||
AMREX_FORCE_INLINE AMREX_GPU_HOST_DEVICE auto RadSystem<TophatProblem>::ComputeFluxMeanOpacity(const double rho, const double /*Tgas*/) | ||||||
-> quokka::valarray<double, nGroups_> | ||||||
AMREX_FORCE_INLINE AMREX_GPU_HOST_DEVICE auto RadSystem<TophatProblem>::ComputeFluxMeanOpacity(const double rho, | ||||||
const double /*Tgas*/) -> quokka::valarray<double, nGroups_> | ||||||
{ | ||||||
return ComputePlanckOpacity(rho, 0.); | ||||||
} | ||||||
|
||||||
static constexpr int nmscalars_ = Physics_Traits<TophatProblem>::numMassScalars; | ||||||
template <> | ||||||
AMREX_FORCE_INLINE AMREX_GPU_HOST_DEVICE auto | ||||||
quokka::EOS<TophatProblem>::ComputeTgasFromEint(const double rho, const double Egas, std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> /*massScalars*/) | ||||||
-> double | ||||||
quokka::EOS<TophatProblem>::ComputeTgasFromEint(const double rho, const double Egas, | ||||||
std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> /*massScalars*/) -> double | ||||||
{ | ||||||
return Egas / (rho * c_v); | ||||||
} | ||||||
|
||||||
template <> | ||||||
AMREX_FORCE_INLINE AMREX_GPU_HOST_DEVICE auto | ||||||
quokka::EOS<TophatProblem>::ComputeEintFromTgas(const double rho, const double Tgas, std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> /*massScalars*/) | ||||||
-> double | ||||||
quokka::EOS<TophatProblem>::ComputeEintFromTgas(const double rho, const double Tgas, | ||||||
std::optional<amrex::GpuArray<amrex::Real, nmscalars_>> /*massScalars*/) -> double | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. warning: parameter 'massScalars' is unused [misc-unused-parameters]
Suggested change
|
||||||
{ | ||||||
return rho * c_v * Tgas; | ||||||
} | ||||||
|
Check notice
Code scanning / CodeQL
Large object passed by value Note