ChatRoomWidget: remove one extra newline in quotes #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's unfortunately not extra. This is to provide compatibility with Markdown that needs this extra line to mark the end of citation. There should be a configuration option when Quaternion supports Markdown but in the meantime I'd prefer to keep the "extra" newline as the default, as long as discontent users can change that in the configuration. |
|
You're right, I forgot, but when we quote a message that has more than one line, it will also add an empty line between the quoted lines (which I don't think is the intended effect). |
|
Ouch, no it's not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.