Added 'Replace next' and 'Replace all' to Find command in Script Editor #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
melvingelbard
commented
Jan 24, 2022
melvingelbard
commented
- Added 'Replace next' and 'Replace all' to Find command
- Fixed 'Previous' button that would search for the next occurrence instead of the previous one
- Improved UX
- Fixed find command window losing its owner whenever the Script Editor is closed
- Added 'Replace next' and 'Replace all' to Find command - Fixed 'Previous' button that would search for the next occurrence instead of the previous one - Improved UX - Fixed find command window losing its owner whenever the Script Editor would be closed
- 'Find' window is now called 'Find/Replace' - Improved the user experience of using the 'Find/Replace' command (mainly 'Next' button is looking like it's focused to indicate what the action will be when pressing Enter on a textfield) - Fixed behaviour to work both on Windows and MacOS - Fixed 'Replace all' - Changed 'Replace next' by 'Replace/Find' for better UX
- Renamed "Find" to "Next" for consistency - Replace all now replace all the text at once. Ctrl/CMD + Z now undoes all the replacements at once, instead of one by one - Ignore case checkbox state is now saved when reopening the "Find/replace" window - Fixed minor bug where hitting Ctrl/CMD + F on a tab would throw an Exception
- Fixed 'undo' after 'Replace all' (it would undo one query at a time, now it undoes all at once) - Added label next to "Next" button in case 'Previous' or 'Next' doesn't find any matching query. - 'Replace all' does not match regex anymore (inputting '.' would have replaced all the characters in the text, now it only replaces all the occurrences of '.' in the text)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.