Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added 'Replace next' and 'Replace all' to Find command in Script Editor #898

Merged
merged 7 commits into from
Feb 7, 2022
Merged

Added 'Replace next' and 'Replace all' to Find command in Script Editor #898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ff2deb2
Added 'Replace next' and 'Replace all' to Find command
melvingelbard Jan 24, 2022
b55fd75
Update CHANGELOG.md
melvingelbard Jan 24, 2022
7ea7304
Improved UX in FInd/Replace command
melvingelbard Jan 28, 2022
65fb1e1
Merge branch 'main' into findCommand
melvingelbard Feb 1, 2022
424f611
Renamed "Find" to "Next" & improved 'Replace all'
melvingelbard Feb 3, 2022
c520509
Merge remote-tracking branch 'upstream/main' into findCommand
melvingelbard Feb 3, 2022
a9a60ea
Fixed 'undo' after 'Replace all'
melvingelbard Feb 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ This is a work-in-progress.

### Bugs fixed
* Reading from Bio-Formats blocks forever when using multiple series outside a project (https://github.com/qupath/qupath/issues/894)
* 'Ignore case' in the Find window of the Script editor does not ignore case (https://github.com/qupath/qupath/issues/889)
* Owner of Find window in the script editor is lost when the script editor window is closed (https://github.com/qupath/qupath/issues/893)

### Enhancements
* Added 'Replace next' and 'Replace all' features to the Find window in the script editor


## Version 0.3.2
Expand Down
4 changes: 2 additions & 2 deletions ...ion-script-editor/src/main/java/qupath/lib/gui/scripting/richtextfx/RichScriptEditor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,8 +638,8 @@ public IndexRange getSelection() {
}

@Override
public void selectRange(int anchor, int caretPosition) {
textArea.selectRange(anchor, caretPosition);
public void selectRange(int startIdx, int endIdx) {
textArea.selectRange(startIdx, endIdx);
}

@Override
Expand Down