-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tries to compile fugitive buffer #55
Comments
Other times, and I have not quite found a pattern to it yet, |
Hi, @felixSchl. I reproduced this. As you said, my plugin attempts to compile buffers created by fugitive I'll fix it. |
@Quramy I am still having the same issue, only with vim-gitgutter. (I also have vim-fugitive installed, but that doesn't seem to be a problem since I think your commit referenced in this issue solved that problem, thanks!) When I attempt to save a To reproduce, make sure you have vim-gitgutter and tsuquyomi installed. Open a I know that it has to be a mismatch between the two of these plugins because it only affects |
When I run @felixSchl's continuing in BufWritePost Auto commands for "*"
Executing BufWritePost Auto commands for "*.ts"
autocommand silent! call tsuquyomi#reloadAndGeterr()
line 0: silent! call tsuquyomi#reloadAndGeterr() |
I have found a nice way to profile the runtime based on the accepted answer to this SO question: http://stackoverflow.com/questions/12213597/how-to-see-which-plugins-are-making-vim-slow Here are the function and file runtimes for when I run broken-and-slow.log
Here are the function and file runtimes for when I run working-and-fast.log
|
You can see that the
|
Hmm. So I changed plugins to display signs for git diff in the gutter to a forked project of I will use this My guess is that it's still |
Hi @indiesquidge . I installed |
@Quramy I can't figure out what the exact problem is either, nor am I willing to pour too many more hours into it since |
@indiesquidge Are you using neovim? I think it is a neovim-specific problem.... |
Neovim user with vim-gutter. I had the same problem. Changed to vim-lazygutter solved the problem for me. |
Another hit for nvim+gitgutter. |
@faceleg It seems gitgutter uses nvim's async feature and nvim hangs. |
Interesting, I only noticed it when I started using tsuquyomi |
I'm vim-gitgutter's author and I've only just come across this issue. vim-gitgutter uses nvim's async feature; I believe vim-gitgutter uses it correctly but please let me know if you see any improvements I could make. |
@airblade I am not convinced it is vim-gitgutter's fault in this instance, as I've used it for years without issue. This hanging only began when I started using TS and Tsuquyomi. My gut feeling is that there is somehow an interaction between gitgutter and tsuquyomi, but I have no proof or time to provide any. |
@faceleg I agree. vim-gitgutter doesn't do anything unusual with neovim's async; it uses it as per the documentation. However I don't have time to dig through tsuquyomi or vimproc or neovim either. |
@HerringtonDarkholme yeah I'm using I reinstalled Chiming in with everyone else, I don't have the time (nor the expertise) to dig through I'll report back when I have done more digging. |
I think this can be closed via airblade/vim-gitgutter@530bf68 |
So vim-gitgutter with disabled asynchronous diffs solves the problem? |
@zbindenren Yes |
Hello, I'm getting this same issue with MacVim (v8.0). I did the same debugging routine and these are the results:
I've completely cleaned out my .vimrc to disable all other plugins and fortunately I have a reliable repro to get it to hang. Also of note I've never used |
I think this plugin tries to compile the file in the fugitive staging buffer somehow and fails badly. It also gets stuck, so I have to
<C-C>
out of it constantly.To reproduce, install fugitive, open a file under source control and when editing the file in vim, run
:Gvd
. Then, edit the staged file by e.g. adding some hunks or making any changes and save the file.This is the last lines of output from running
:20verbose w
in that buffer:Also note it only happens for typescript files, that is for files of
filetype
typescript
(the staging buffer will have the same filetype as the original file).The text was updated successfully, but these errors were encountered: