New Footer Style #38
New Footer Style #38
Conversation
- Define default style for hyperlink and heading
|
This pull request is being automatically deployed with Vercel (learn more). |
|
@nabeel- any idea why the test actions are not being fun? |
|
@mmahalwy can you check why Vercel deployment taking too long? |
src/components/Footer.tsx
Outdated
| import React from 'react'; | ||
| import { Container } from 'styled-bootstrap-grid'; | ||
| import styled from 'styled-components'; | ||
| import React from "react"; |
There was a problem hiding this comment.
@nabeel- I feel like ESlint should have caught double quotes here, no?
There was a problem hiding this comment.
I think its better if we have prettier on the development level, as in during the coding time and it will auto format on save
@MistaPidaus Agreed! We had this in the commit/PR I mentioned above but it seems to have disappeared from master. There is also a pre-commit hook that will auto-fix errors, too
There was a problem hiding this comment.
@nabeel- I see. It looks like it.
Please, no more force push. It will ruin the project.
|
@MistaPidaus left some comments |
- Line height value to rem
…next into enhance/footer
|
@mmahalwy updated the PR |
|
@mmahalwy Updated PR |
|
@mmahalwy added story |
Enhance/Improve Footer styling based on #9
cc: @mmahalwy