Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pull_request event to GH action triggers and fix a lint warning #41

Merged
merged 5 commits into from Jun 26, 2020

Conversation

nabeel-
Copy link
Contributor

@nabeel- nabeel- commented Jun 26, 2020

Mainly to test a theory on the GH actions wonkiness

@vercel
Copy link

vercel bot commented Jun 26, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/qurancom/quran-com-frontend-next/piuqkornq
✅ Preview: https://quran-com-frontend-next-git-fork-nabeel-nehactions.qurancom.vercel.app

@vercel vercel bot temporarily deployed to Preview June 26, 2020 00:02 Inactive
@nabeel-
Copy link
Contributor Author

nabeel- commented Jun 26, 2020

oh. @mmahalwy it doesn't trigger since these are pushes to a fork of the repo and not the repo itself 🤦

@nabeel- nabeel- changed the title Add explicit return type to pages/_app.tsx Add pull_request event to GH action triggers and fix a lint warning Jun 26, 2020
@nabeel- nabeel- requested a review from mmahalwy June 26, 2020 00:36
@nabeel- nabeel- mentioned this pull request Jun 26, 2020
Copy link
Contributor

@mmahalwy mmahalwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY for this!

@mmahalwy mmahalwy merged commit 7fb0d11 into quran:master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants