Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repeat Verse Plays 1 more time [BUG] #499

Closed
guneysus opened this issue Mar 18, 2015 · 3 comments
Closed

Repeat Verse Plays 1 more time [BUG] #499

guneysus opened this issue Mar 18, 2015 · 3 comments

Comments

@guneysus
Copy link

Repeat mode plays verses 1 more time. The main reason should be star counter starts from 0.

screenshot_2015-03-18-12-16-08
@ahmedre
Copy link
Contributor

ahmedre commented Mar 23, 2015

this isn't a bug, it's intentional. repeat "1 time" means you repeat the verse 1 time. repeat "never" means "never repeat this verse" (so only say it once).

@ahmedre ahmedre closed this as completed Mar 23, 2015
@guneysus
Copy link
Author

It is a little bit confusing. Because never repeat is never used. But there is an option.
I want to listen a verse 3 times, but have to select 2?
screenshot_2015-03-23-17-52-08

@ahmedre ahmedre reopened this Mar 23, 2015
@ahmedre
Copy link
Contributor

ahmedre commented Mar 23, 2015

jazakAllah khairan, agreed, you have a good point. We should change it to "play set of verses x times" and "play each verse x times"

ahmedre added a commit that referenced this issue Oct 14, 2017
@ahmedre
Change "repeat verses" wording to be less confusing.
1c76021 
Instead of "repeat each verse" and "repeat set of verses" text which are
a bit confusing, instead replace them with more clear "play each verse"
and "play set of verses" strings. This way, instead of saying, "repeat
each verse never," you would say, "play each verse once."

Fixes #499.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahmedre @guneysus