Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: jump to ayah by using EditText instead of drop-down Spinner #799

Closed
fikr4n opened this issue Feb 4, 2017 · 5 comments
Closed

Comments

@fikr4n
Copy link
Contributor

fikr4n commented Feb 4, 2017

السلام عليكم

Is there any planning to change drop-down Spinner of ayah number in "jump to page or surah & ayah" dialog to text field? I think it is easier to type ayah number instead of scrolling in case that the surah is long (has many ayahs). As for the surahs drop-down, how about replacing it with auto-complete text field which also has drop-down (like in the search box at the top bar)?

It's just an idea, based on my experience of a little difficulty when navigating.

@fikr4n
Copy link
Contributor Author

fikr4n commented Feb 9, 2017

What I meant was like this. It is only a prototype, of course the code is still dirty.

@ozbek
Copy link
Contributor

ozbek commented Feb 10, 2017

Wa alaikum assalam.

Can you clean up the change (eg., remove android.util.Log, commented out code) and send a pull request? It'd be easier to follow your changes that way.

@ahmedre
Copy link
Contributor

ahmedre commented Feb 10, 2017

wa3laikum alsalam,
i think it should be both autocomplete and spinner.
walsalam 3alaikum

@fikr4n
Copy link
Contributor Author

fikr4n commented Feb 11, 2017

I've created the pull request. Not sure if it is what @ahmedre called "both autocomplete and spinner".

@ahmedre
Copy link
Contributor

ahmedre commented Mar 20, 2017

jazakAllah khairan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants