Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show footnotes inline #2207

Merged
merged 1 commit into from
Feb 25, 2023
Merged

Show footnotes inline #2207

merged 1 commit into from
Feb 25, 2023

Conversation

ahmedre
Copy link
Contributor

@ahmedre ahmedre commented Feb 25, 2023

Previously, footnotes were being removed. This patch updates it so that
footnotes are added inline while reading instead.

@ahmedre
Copy link
Contributor Author

ahmedre commented Feb 25, 2023

light
dark

@ahmedre
Copy link
Contributor Author

ahmedre commented Feb 25, 2023

this is a similar approach to what @mohamede1945 did in quran/quran-ios. the nice thing about it is it's simpler. I spent some time thinking about this but unsure about the ux for other approaches (ex having a superscript and clicking shows the footnote - in this case, where do we show it? bottom sheet? dialog? what if the footnote is super short? super long? etc).

Previously, footnotes were being removed. This patch updates it so that
footnotes are added inline while reading instead.
@github-actions
Copy link

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │  11.8 MiB │  11.8 MiB │ +2.2 KiB │  30.1 MiB │  30.1 MiB │ +5.6 KiB 
     arsc │   1.9 MiB │   1.9 MiB │    +68 B │   1.9 MiB │   1.9 MiB │    +68 B 
 manifest │   5.8 KiB │   5.8 KiB │      0 B │  28.6 KiB │  28.6 KiB │      0 B 
      res │   1.5 MiB │   1.5 MiB │     +2 B │   1.7 MiB │   1.7 MiB │      0 B 
    asset │ 404.2 KiB │ 404.2 KiB │      0 B │ 678.6 KiB │ 678.6 KiB │      0 B 
    other │ 181.2 KiB │ 181.2 KiB │     -2 B │ 365.6 KiB │ 365.6 KiB │      0 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │  15.8 MiB │  15.8 MiB │ +2.3 KiB │  34.7 MiB │  34.7 MiB │ +5.7 KiB 


@ahmedre ahmedre merged commit d297807 into master Feb 25, 2023
@ahmedre ahmedre deleted the footnotes branch February 25, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant