Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix last page not appearing for Shemerly on tablet #2210

Merged
merged 1 commit into from Mar 2, 2023
Merged

Conversation

ahmedre
Copy link
Contributor

@ahmedre ahmedre commented Mar 1, 2023

The Shemerly mushaf has an odd number of pages. In dual screen mode when
translations are turned off (i.e. 2 mushaf pages), the last page was not
appearing due to it being out of bounds. This patch allows the last page
to be empty.

The Shemerly mushaf has an odd number of pages. In dual screen mode when
translations are turned off (i.e. 2 mushaf pages), the last page was not
appearing due to it being out of bounds. This patch allows the last page
to be empty.
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │  11.8 MiB │  11.9 MiB │ +1,011 B │  30.1 MiB │  30.1 MiB │ +2.1 KiB 
     arsc │   1.9 MiB │   1.9 MiB │      0 B │   1.9 MiB │   1.9 MiB │      0 B 
 manifest │   5.8 KiB │   5.8 KiB │      0 B │  28.6 KiB │  28.6 KiB │      0 B 
      res │   1.5 MiB │   1.5 MiB │      0 B │   1.7 MiB │   1.7 MiB │      0 B 
    asset │ 404.2 KiB │ 404.2 KiB │      0 B │ 678.6 KiB │ 678.6 KiB │      0 B 
    other │ 181.2 KiB │ 181.2 KiB │     +5 B │ 365.6 KiB │ 365.6 KiB │      0 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │  15.8 MiB │  15.8 MiB │ +1,016 B │  34.7 MiB │  34.7 MiB │ +2.1 KiB 


@ahmedre ahmedre merged commit 7042da4 into master Mar 2, 2023
@ahmedre ahmedre deleted the fix_shemerly branch March 2, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant