Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observe stream of translations in PagerActivity #2488

Merged
merged 1 commit into from Dec 10, 2023

Conversation

ahmedre
Copy link
Contributor

@ahmedre ahmedre commented Dec 9, 2023

This patch updates PagerActivity and the InlineTranslations
functionality to observe the list of translations as they are updated
from the database. This solves issues like translations not showing up
right when they are added without returning to the menu and coming back.
Fixes #2460.

This patch updates PagerActivity and the InlineTranslations
functionality to observe the list of translations as they are updated
from the database. This solves issues like translations not showing up
right when they are added without returning to the menu and coming back.
Fixes #2460.
Copy link

github-actions bot commented Dec 9, 2023

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │  12.6 MiB │  12.6 MiB │ +1.9 KiB │    32 MiB │    32 MiB │ +5.6 KiB 
     arsc │   2.2 MiB │   2.2 MiB │      0 B │   2.2 MiB │   2.2 MiB │      0 B 
 manifest │   5.6 KiB │   5.6 KiB │      0 B │  27.1 KiB │  27.1 KiB │      0 B 
      res │   1.6 MiB │   1.6 MiB │      0 B │   1.8 MiB │   1.8 MiB │      0 B 
    asset │ 404.2 KiB │ 404.2 KiB │      0 B │ 678.6 KiB │ 678.6 KiB │      0 B 
    other │ 188.2 KiB │ 188.3 KiB │    +29 B │ 384.8 KiB │ 384.8 KiB │      0 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │    17 MiB │    17 MiB │   +2 KiB │    37 MiB │    37 MiB │ +5.6 KiB 


@ahmedre ahmedre merged commit bf1026a into master Dec 10, 2023
4 checks passed
@ahmedre ahmedre deleted the observe_translations_reading branch December 10, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translation list doesn't refresh properly
1 participant