Add quotes for strings in javascript.assemble

qutebrowser · Aug 4, 2016 · a8ef956 · a8ef956
1 parent 08b70f0
commit a8ef956
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/qutebrowser/utils/javascript.py b/qutebrowser/utils/javascript.py
@@ -54,7 +54,7 @@ def _convert_js_arg(arg):
     if arg is None:
         return 'undefined'
     elif isinstance(arg, str):
-        return string_escape(arg)
+        return '"{}"'.format(string_escape(arg))
     elif isinstance(arg, int):
         return str(arg)
     else:

diff --git a/tests/unit/utils/test_javascript.py b/tests/unit/utils/test_javascript.py
@@ -123,8 +123,8 @@ def test_real_escape_hypothesis(self, webframe, qtbot, text):
 
 
 @pytest.mark.parametrize('arg, expected', [
-    ('foobar', 'foobar'),
-    ('foo\\bar', r'foo\\bar'),
+    ('foobar', '"foobar"'),
+    ('foo\\bar', r'"foo\\bar"'),
     (42, '42'),
     (None, 'undefined'),
     (object(), TypeError),