New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running ":" as command -> IndexError #1690

Closed
The-Compiler opened this Issue Jul 26, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@The-Compiler
Collaborator

The-Compiler commented Jul 26, 2016

Since #1577, when doing :<Enter> or qutebrowser --debug --temp-basedir ': ' we get:

Traceback (most recent call last):
  File "/home/florian/proj/qutebrowser/git/qutebrowser/app.py", line 202, in _process_args
    process_pos_args(args.command)
  File "/home/florian/proj/qutebrowser/git/qutebrowser/app.py", line 262, in process_pos_args
    commandrunner.run_safely_init(cmd[1:])
  File "/home/florian/proj/qutebrowser/git/qutebrowser/commands/runners.py", line 304, in run_safely_init
    self.run(text, count)
  File "/home/florian/proj/qutebrowser/git/qutebrowser/commands/runners.py", line 274, in run
    for result in self.parse_all(text):
  File "/home/florian/proj/qutebrowser/git/qutebrowser/commands/runners.py", line 123, in parse_all
    text = self._get_alias(text, text)
  File "/home/florian/proj/qutebrowser/git/qutebrowser/commands/runners.py", line 97, in _get_alias
    alias = config.get('aliases', parts[0])
IndexError: list index out of range

@mgoral do you want to fix that one? 😉

@The-Compiler

This comment has been minimized.

Show comment
Hide comment
@The-Compiler

The-Compiler Jul 27, 2016

Collaborator

Already three crash reports for this, I guess I'll need to do a small v0.8.1 release for this today.

Collaborator

The-Compiler commented Jul 27, 2016

Already three crash reports for this, I guess I'll need to do a small v0.8.1 release for this today.

The-Compiler added a commit that referenced this issue Jul 27, 2016

Handle empty command in CommandRunner.parse_all
Sicne we now call self._get_alias there, we also need to make sure it's
not an empty string before that.

Introduced in #1577. Fixes #1690.
@mgoral

This comment has been minimized.

Show comment
Hide comment
@mgoral

mgoral Jul 28, 2016

Contributor

@The-Compiler: sorry, I haven't seen a notification from github till now. As I understand you fixed it for me, right? :)

Contributor

mgoral commented Jul 28, 2016

@The-Compiler: sorry, I haven't seen a notification from github till now. As I understand you fixed it for me, right? :)

@The-Compiler

This comment has been minimized.

Show comment
Hide comment
@The-Compiler

The-Compiler Jul 28, 2016

Collaborator

Yep - I fixed it in a84807e and did a v0.8.1 release as a lot of crash reports came in 😉

Collaborator

The-Compiler commented Jul 28, 2016

Yep - I fixed it in a84807e and did a v0.8.1 release as a lot of crash reports came in 😉

@mgoral

This comment has been minimized.

Show comment
Hide comment
@mgoral

mgoral Jul 28, 2016

Contributor

Thanks! And I wondered what jackass made you release such quick update. ;)

Contributor

mgoral commented Jul 28, 2016

Thanks! And I wondered what jackass made you release such quick update. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment