Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running ":" as command -> IndexError #1690

Closed
The-Compiler opened this issue Jul 26, 2016 · 4 comments
Closed

Running ":" as command -> IndexError #1690

The-Compiler opened this issue Jul 26, 2016 · 4 comments
Labels
component: completion Issues related to the commandline completion or history. priority: 0 - high Issues which are currently the primary focus.

Comments

@The-Compiler
Copy link
Member

Since #1577, when doing :<Enter> or qutebrowser --debug --temp-basedir ': ' we get:

Traceback (most recent call last):
  File "/home/florian/proj/qutebrowser/git/qutebrowser/app.py", line 202, in _process_args
    process_pos_args(args.command)
  File "/home/florian/proj/qutebrowser/git/qutebrowser/app.py", line 262, in process_pos_args
    commandrunner.run_safely_init(cmd[1:])
  File "/home/florian/proj/qutebrowser/git/qutebrowser/commands/runners.py", line 304, in run_safely_init
    self.run(text, count)
  File "/home/florian/proj/qutebrowser/git/qutebrowser/commands/runners.py", line 274, in run
    for result in self.parse_all(text):
  File "/home/florian/proj/qutebrowser/git/qutebrowser/commands/runners.py", line 123, in parse_all
    text = self._get_alias(text, text)
  File "/home/florian/proj/qutebrowser/git/qutebrowser/commands/runners.py", line 97, in _get_alias
    alias = config.get('aliases', parts[0])
IndexError: list index out of range

@mgoral do you want to fix that one? 😉
@The-Compiler The-Compiler added component: completion Issues related to the commandline completion or history. priority: 0 - high Issues which are currently the primary focus. labels Jul 26, 2016
@The-Compiler
Copy link
Member Author

Already three crash reports for this, I guess I'll need to do a small v0.8.1 release for this today.

The-Compiler added a commit that referenced this issue Jul 27, 2016
@The-Compiler
Handle empty command in CommandRunner.parse_all
a84807e 
Sicne we now call self._get_alias there, we also need to make sure it's
not an empty string before that.

Introduced in #1577. Fixes #1690.
@mgoral
Copy link

mgoral commented Jul 28, 2016

@The-Compiler: sorry, I haven't seen a notification from github till now. As I understand you fixed it for me, right? :)

@The-Compiler
Copy link
Member Author

Yep - I fixed it in a84807e and did a v0.8.1 release as a lot of crash reports came in 😉

@mgoral
Copy link

mgoral commented Jul 28, 2016

Thanks! And I wondered what jackass made you release such quick update. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: completion Issues related to the commandline completion or history. priority: 0 - high Issues which are currently the primary focus.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@The-Compiler @mgoral