Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tab numbers are ordered alphabetically with new completion #2883

Closed
The-Compiler opened this issue Aug 2, 2017 · 0 comments · Fixed by #2888
Closed

Tab numbers are ordered alphabetically with new completion #2883

The-Compiler opened this issue Aug 2, 2017 · 0 comments · Fixed by #2888
Labels
bug: behavior Something doesn't work as intended, but doesn't crash. component: completion Issues related to the commandline completion or history. priority: 2 - low Issues which are currently not very important.

Comments

@The-Compiler
Copy link
Member

In the :buffer completion, tabs are ordered like 0/1, 0/10, 0/11, 0/2 if there are >10. This wasn't the case with v0.11.0.

cc @rcorre
@The-Compiler The-Compiler added bug: behavior Something doesn't work as intended, but doesn't crash. component: completion Issues related to the commandline completion or history. priority: 2 - low Issues which are currently not very important. labels Aug 2, 2017
rcorre added a commit to rcorre/qutebrowser that referenced this issue Aug 5, 2017
@rcorre
Don't perform alphabetical sort in listcategory.
36ff215 
Instead, expect the data to be given in the desired order. Completion
functions should sort their data _if_ they want it sorted in the
completion. This has a few implications:

- {book,quick}marks appear in the same order they do in the text file.
  This means users can rearrange their mark files for custom sorting.
- Sessions are sorted as they appear in the session manager
- Tabs are sorted numerically, not alphabetically (Fixes qutebrowser#2883)

Note that prefix-based filter sorting is still performed, so items
starting with the filter pattern come first.
@rcorre rcorre mentioned this issue Aug 5, 2017
Merged
rcorre added a commit to rcorre/qutebrowser that referenced this issue Aug 6, 2017
@rcorre
Don't perform alphabetical sort in listcategory.
6e025c1 
Instead, expect the data to be given in the desired order. Completion
functions should sort their data _if_ they want it sorted in the
completion. This has a few implications:

- {book,quick}marks appear in the same order they do in the text file.
  This means users can rearrange their mark files for custom sorting.
  Fixes qutebrowser#2354
- Sessions are sorted as they appear in the session manager
- Tabs are sorted numerically, not alphabetically (Fixes qutebrowser#2883)

Note that prefix-based filter sorting is still performed, so items
starting with the filter pattern come first.
@The-Compiler The-Compiler mentioned this issue Aug 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug: behavior Something doesn't work as intended, but doesn't crash. component: completion Issues related to the commandline completion or history. priority: 2 - low Issues which are currently not very important.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't perform alphabetical sort in listcategory. rcorre/qutebrowser
1 participant
@The-Compiler