Don't perform alphabetical sort in listcategory. #2888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suppose this also fixes #2354. 😉 |
Instead, expect the data to be given in the desired order. Completion
functions should sort their data _if_ they want it sorted in the
completion. This has a few implications:
- {book,quick}marks appear in the same order they do in the text file.
This means users can rearrange their mark files for custom sorting.
Fixes qutebrowser#2354
- Sessions are sorted as they appear in the session manager
- Tabs are sorted numerically, not alphabetically (Fixes qutebrowser#2883)
Note that prefix-based filter sorting is still performed, so items
starting with the filter pattern come first.
|
Yup, just referenced that in the commit message. Also a geolocation test is broken but it doesn't appear to be my fault 😁 |
|
81b2609 hopefully helps with the geoclue error - I already had it fixed in the |
|
Thanks! I also added sorting for the sessions in a20f017 (as they'd just be randomly ordered based on how they're stored on disk). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, expect the data to be given in the desired order. Completion
functions should sort their data if they want it sorted in the
completion. This has a few implications:
This means users can rearrange their mark files for custom sorting.
Note that prefix-based filter sorting is still performed, so items
starting with the filter pattern come first.
This change is