Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use importlib.resources for icons #6062

Closed
The-Compiler opened this issue Jan 26, 2021 · 0 comments · Fixed by #7103
Closed

Use importlib.resources for icons #6062

The-Compiler opened this issue Jan 26, 2021 · 0 comments · Fixed by #7103
Labels
component: style / refactoring Issues related to coding styles or code that should be refactored. priority: 1 - middle Issues which should be done at some point, but aren't that important.
Milestone
v3.0.0

Comments

@The-Compiler
Copy link
Member

Split off from #4467. Note that icons/ is outside of the qutebrowser/ package... We might need to move it in there so that we can pick them up as package data properly...
@The-Compiler The-Compiler added component: style / refactoring Issues related to coding styles or code that should be refactored. priority: 1 - middle Issues which should be done at some point, but aren't that important. labels Jan 26, 2021
@The-Compiler The-Compiler mentioned this issue Jan 26, 2021
Closed
@The-Compiler The-Compiler added this to the v3.0.0 milestone Jan 26, 2021
This was referenced Oct 4, 2021
Merged
Closed
@toofar toofar mentioned this issue Apr 4, 2022
Merged
twigleingrid pushed a commit to twigleingrid/qutebrowser that referenced this issue May 13, 2022
@toofar @twigleingrid
Load icons via importlib.resources
755bbf6 
The PyQt resources system is gone in 6.2 and deprecated before that. This
should be the last usage of it.

Switches icons to be read with `utils.resources.read_file_binary()` in
`notification.py` (fallback desktop notification icon) and `app.py` (icon for
the desktop window).

importlib only loads resources under a package, so the icons are moved under
the `qutebrowser/` directory.

Closes: qutebrowser#6062
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: style / refactoring Issues related to coding styles or code that should be refactored. priority: 1 - middle Issues which should be done at some point, but aren't that important.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging a pull request may close this issue.

Load icons via importlib.resources qutebrowser/qutebrowser
1 participant
@The-Compiler