Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add timeout after auto-followed hint #1185

Closed
wants to merge 1 commit into from

Conversation

lahwaacz
Copy link
Contributor

Possible solution to #72, seems to work sufficiently well.

Disclaimer: I've been staring at the code for only a few hours, so there are most likely many things that should be done differently. For example I have no idea what is the proper way to introduce new configuration options...

Review on Reviewable

@codecov-io
Copy link

Current coverage is 68.77%

Merging #1185 into master will decrease coverage by -0.27% as of a7736f8

@@            master   #1185   diff @@
======================================
  Files          102     102       
  Stmts        13889   13907    +18
  Branches      2191    2195     +4
  Methods          0       0       
======================================
- Hit           9589    9564    -25
- Partial        419     428     +9
- Missed        3881    3915    +34

Review entire Coverage Diff as of a7736f8

Powered by Codecov. Updated on successful CI builds.

@The-Compiler
Copy link
Member

I'll take a closer look later, but it looks quite good from a first quick look!

@The-Compiler The-Compiler mentioned this pull request Dec 18, 2015
@lahwaacz
Copy link
Contributor Author

I've included the commit in #1194, so I'll close this in the meantime...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants