Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for completion uniform height #7296

Closed
wants to merge 0 commits into from
Closed

Add option for completion uniform height #7296

wants to merge 0 commits into from

Conversation

illfygli
Copy link
Contributor

@illfygli illfygli commented Jul 6, 2022 •
edited
Loading

As discussed in #2112, adds an option that is passed to setUniformRowHeights to address rendering issues.

Added a warning due to the past issues with Qt, and possible perfomance impact.

Default is true which keeps the current behavior.

@illfygli illfygli requested a review from rcorre as a code owner July 6, 2022 18:21
The-Compiler
The-Compiler requested changes Jul 6, 2022
View reviewed changes
Copy link
Member

@The-Compiler The-Compiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need some changes so that the option can be changed at runtime with :set: Move the setter into a function, and then call that accordingly from __init__ and _on_config_changed.

@illfygli
Copy link
Contributor Author

illfygli commented Jul 6, 2022

Thanks, updated it to do that.

@illfygli illfygli closed this Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcorre rcorre Awaiting requested review from rcorre

@The-Compiler The-Compiler Awaiting requested review from The-Compiler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illfygli @The-Compiler