Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make offset and amplitude handling of the Tabor AWG configurable #453

Merged
merged 3 commits into from
Apr 25, 2019

Conversation

lankes-fzj
Copy link
Contributor

The Tabor AWG has a new attribute "amplitude_offset_handling". Now it is possible to consider the offset when uploading a program to the instrument.

This pull request belongs to #446

… is possible to consider the offset when uploading a program to the instrument
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1743

  • 16 of 18 (88.89%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 93.624%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qupulse/hardware/awgs/base.py 11 12 91.67%
qupulse/hardware/awgs/tabor.py 5 6 83.33%
Totals Coverage Status
Change from base Build 1741: 0.006%
Covered Lines: 4811
Relevant Lines: 5070

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1743

  • 16 of 18 (88.89%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 93.624%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qupulse/hardware/awgs/base.py 11 12 91.67%
qupulse/hardware/awgs/tabor.py 5 6 83.33%
Totals Coverage Status
Change from base Build 1741: 0.006%
Covered Lines: 4811
Relevant Lines: 5070

💛 - Coveralls

@coveralls
Copy link

coveralls commented Apr 25, 2019

Pull Request Test Coverage Report for Build 1747

  • 17 of 18 (94.44%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 93.723%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qupulse/hardware/awgs/base.py 11 12 91.67%
Totals Coverage Status
Change from base Build 1741: 0.1%
Covered Lines: 4815
Relevant Lines: 5070

💛 - Coveralls

@lankes-fzj lankes-fzj merged commit 440528b into master Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants