Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing of qutip_dev_contrib.md to CONTRIBUTING.md as issue 111 in qutip/qutip-doc #1270

Merged
merged 2 commits into from
May 21, 2020

Conversation

Alexios-xi
Copy link
Contributor

Checklist
Thank you for contributing to QuTiP! Please make sure you have finished the following tasks before opening the PR.

  • Please read Contributing to QuTiP Development
  • Contributions to qutip should follow the pep8 style.
    You can use pycodestyle to check your code automatically
  • Please add tests to cover your changes if applicable.
  • If the behavior of the code has changed or new feature has been added, please also update the documentation and the notebook. Feel free to ask if you are not sure.

Delete this checklist after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work and keep this checklist in the PR description.

Description
Describe here the proposed change.

Related issues or PRs
Please mention the related issues or PRs here. If the PR fixes an issue, use the keyword fix/fixes/fixed followed by the issue id, e.g. fix #1184

Changelog
Give a short description of the PR in a few words. This will be shown in the QuTiP change log after the PR gets merged.
For example:
Fixed error checking for null matrix in essolve.
Added option for specifying resolution in Bloch.save function.

@Alexios-xi Alexios-xi changed the title Changing of qutip_dev_contrib.md to CONTRIBUTING.md as issue #111 in qutip/qutip-doc Changing of qutip_dev_contrib.md to CONTRIBUTING.md as issue 111(https://github.com/qutip/qutip-doc/issues/111) in qutip/qutip-doc May 21, 2020
@Alexios-xi Alexios-xi changed the title Changing of qutip_dev_contrib.md to CONTRIBUTING.md as issue 111(https://github.com/qutip/qutip-doc/issues/111) in qutip/qutip-doc Changing of qutip_dev_contrib.md to CONTRIBUTING.md as issue 111 in qutip/qutip-doc May 21, 2020
@Alexios-xi Alexios-xi changed the title Changing of qutip_dev_contrib.md to CONTRIBUTING.md as issue 111 in qutip/qutip-doc Changing of qutip_dev_contrib.md to CONTRIBUTING.md as issue [111](https://github.com/qutip/qutip-doc/issues/111) in qutip/qutip-doc May 21, 2020
@Alexios-xi Alexios-xi changed the title Changing of qutip_dev_contrib.md to CONTRIBUTING.md as issue [111](https://github.com/qutip/qutip-doc/issues/111) in qutip/qutip-doc Changing of qutip_dev_contrib.md to CONTRIBUTING.md as issue 111 in qutip/qutip-doc May 21, 2020
@jakelishman
Copy link
Member

GitHub doesn't accept markdown in PR titles, but it does in the body of the text (which you should edit to answer the template). You link the other issue just by typing qutip/qutip-doc#111. Thanks for making the PR!

Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick grep of the repository shows that these are the only two references to the file.

@Alexios-xi
Copy link
Contributor Author

@jakelishman Thanks for the tips...Noob here -)

@nathanshammah nathanshammah self-requested a review May 21, 2020 14:38
Copy link
Member

@nathanshammah nathanshammah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @Alexios-xi.

@nathanshammah nathanshammah merged commit be42f4c into qutip:master May 21, 2020
araza6 pushed a commit to araza6/qutip that referenced this pull request May 28, 2020
…utip/qutip-doc (qutip#1270)

* Update README.md

* Update pull_request_template.md
@jakelishman jakelishman added this to the QuTiP 4.6 milestone Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More detailed information for GSoC 2020 project
3 participants