-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close matplotlib figure windows cleanly in tests. #1648
Close matplotlib figure windows cleanly in tests. #1648
Conversation
…produce an obscure error at the end of the test.
@BoxiLi Would you be happy to apply this to @drew-parsons Could you check that this works for you and that I haven't missed any other cases? The entire test suite passed for me, but one never knows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, and I'm happy if it works without the nuclear option of pyplot.close('all')
.
Passes fine for me, patched onto 4.6.2.
|
@jakelishman @drew-parsons Thanks! Merged and marked for inclusion in 4.6.3. |
@hodgestar Thanks for the fix. I'll add it also to |
See qutip/qutip#1648 Co-Authored-By: Simon Cross <165551+hodgestar@users.noreply.github.com> Co-Authored-By: Drew Parsons <26508288+drew-parsons@users.noreply.github.com>
…ot-test-under-xvfb-gh1639 Close matplotlib figure windows cleanly in tests.
Close figure plots explicitly during tests so that the test suite passes when run headless under Xvfb.
Related issues or PRs
Changelog
Close figure plots explicitly during tests so that the test suite passes when run headless under Xvfb.