Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update spectrum to use the data layer #2050

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Update spectrum to use the data layer #2050

merged 1 commit into from
Dec 20, 2022

Conversation

Ericgig
Copy link
Member

@Ericgig Ericgig commented Dec 16, 2022

Description
When I updated correlation to use the data layer in #1997. spectrum was moved to its own file, but was left mostly unchanged.
This update spectrum to use the data layer,

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 70.144% when pulling 1c90dac on Ericgig:spectrum into 5d0ce70 on qutip:dev.major.

hodgestar
hodgestar approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@hodgestar hodgestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Ericgig Ericgig merged commit 001943f into qutip:dev.major Dec 20, 2022
@Ericgig Ericgig deleted the spectrum branch December 20, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hodgestar hodgestar hodgestar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ericgig @coveralls @hodgestar