Modify theming code: custom tab theme is now pulled from TablineSel highlight group #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…group rather than Visual selection background color. Fixes the issue where the everforest theme results in low-contrast tabs, by using color groups that were meant for tabs
|
Thank you a log for the PR! However, I noticed that with darker theme, the close button is not visible in the active tab; could you have a look? I'm using https://github.com/dracula/vim . |
… foreground color for unselected tabs
How is this? I tested it with Dracula, and it looks okay. |
|
There are still pending problems with themes such as 'Ron' and other dark themes... I'll see if I can find an easy solution |
Latest code changes have it rendering like this for me, under the 'ron' theme. Does this work for you? |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue raised in #1058 where the
everforesttheme results in low-contrast tabs, by using color groups that were meant for tabsBefore
After
