Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging improvements #22

Merged
merged 2 commits into from
Jul 29, 2016
Merged

Logging improvements #22

merged 2 commits into from
Jul 29, 2016

Conversation

denge90
Copy link
Contributor

@denge90 denge90 commented Jul 29, 2016

UserAgent Header mit loggen
Besseres Logging von 404ern (Weniger Log-Zeilen), keine Darstellung als Fehler
Bei: 'Fragment not Found' Ausgabe der Liste aller ContentObjekte mit den zugehörigen Fragment-Namen

@@ -120,3 +122,21 @@ func urlToFragmentName(url string) string {
url = strings.Replace(url, `]§`, `\]\§`, -1)
return url
}

// Generates String for the missing Fragment error message. It adds all existing fragments from the body
func generateMissingFragmentString(body map[string]Fragment, fragmentName string) string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit test?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 93.014% when pulling 9ea8348 on minor-logging-improvements into e74b5bd on master.

@domano
Copy link
Contributor

domano commented Jul 29, 2016

+1

@denge90 denge90 merged commit a20264d into master Jul 29, 2016
@domano domano deleted the minor-logging-improvements branch January 31, 2017 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants