Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tOOM-2580: removed duplicate function readCookieValue #42

Merged
merged 1 commit into from
Jan 31, 2017
Merged

tOOM-2580: removed duplicate function readCookieValue #42

merged 1 commit into from
Jan 31, 2017

Conversation

domano
Copy link
Contributor

@domano domano commented Jan 31, 2017

Some old branch (kudos to @rokkbert) with useful changes

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 93.708% when pulling a64325a on TOOM-2580-disable-caching-for-typo3-be-users into e2c6fb3 on master.

@domano
Copy link
Contributor Author

domano commented Jan 31, 2017

I think the decrease in coverage is ok, as we lose duplicate code this way. Your call @rokkbert

rokkbert
rokkbert approved these changes Jan 31, 2017
View reviewed changes
Copy link
Contributor

@rokkbert rokkbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like an ok simplification, to remove the copied code ;-)

@domano domano merged commit 358f7d2 into master Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rokkbert rokkbert rokkbert approved these changes

@denge90 denge90 Awaiting requested review from denge90

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@domano @coveralls @rokkbert