Skip to content
This repository has been archived by the owner on Jul 3, 2021. It is now read-only.

Enh0002 #26

Merged
merged 3 commits into from Jan 3, 2021
Merged

Enh0002 #26

merged 3 commits into from Jan 3, 2021

Conversation

yabetsu93
Copy link
Contributor

remove vendor folder, uses go.mod, uses latest version of the packages and dependencies, and code improvements

@yabetsu93
Copy link
Contributor Author

successfully removed vendor can you test and let me know when can you make a release?

Copy link
Contributor Author

@yabetsu93 yabetsu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls take a look if you have time

@jorinvo
Copy link
Member

jorinvo commented Jan 3, 2021

This is great! Thanks :) Seems like Travis CI also uses go mod dependencies automatically 👌

@jorinvo jorinvo merged commit 4473498 into qvl:master Jan 3, 2021
@yabetsu93
Copy link
Contributor Author

yabetsu93 commented Jan 3, 2021 via email

@jorinvo
Copy link
Member

jorinvo commented Jan 3, 2021

I created a new tag and it's on its way: https://travis-ci.org/github/qvl/promplot/builds/752639093

@yabetsu93
Copy link
Contributor Author

yabetsu93 commented Jan 3, 2021 via email

@yabetsu93
Copy link
Contributor Author

yabetsu93 commented Jan 3, 2021 via email

@jorinvo
Copy link
Member

jorinvo commented Jan 3, 2021

There is no explicit code for installing the dependencies. Travis CI. does it automatically with the default config. We could overwrite the default by with a custom script: ... in the config, but it's not needed.

Also there was a problem in CI. So I made two more commits:
https://github.com/qvl/promplot/commits/master

The release is ready now:
https://github.com/qvl/promplot/releases/tag/v0.17.0

@yabetsu93
Copy link
Contributor Author

yabetsu93 commented Jan 3, 2021 via email

@yabetsu93
Copy link
Contributor Author

yabetsu93 commented Jan 4, 2021 via email

@yabetsu93
Copy link
Contributor Author

yabetsu93 commented Jan 5, 2021 via email

@yabetsu93 yabetsu93 deleted the enh0002 branch January 5, 2021 13:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants