Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

select doesn't work on mobile and desktop #265

Closed
tleperou opened this issue Apr 3, 2023 · 5 comments · Fixed by #301
Closed

select doesn't work on mobile and desktop #265

tleperou opened this issue Apr 3, 2023 · 5 comments · Fixed by #301
Assignees
@a-lukasiewicz
Labels
COMMUNITY: good first issue Good for newcomers TYPE: bug Something isn't working

Comments

@tleperou
Copy link
Contributor

tleperou commented Apr 3, 2023 •
edited
Loading

Summary

The component Select doesn't work properly on mobile, tested on Opera mini and Chrome. It's realy hard to get it open

Note: seems that the floatui struggles to work properly, there's like a layout shifting

image
@tleperou tleperou changed the title select doesn't work on mobile select doesn't work on mobile and desktop Apr 4, 2023
@gioboa gioboa added TYPE: bug Something isn't working COMMUNITY: good first issue Good for newcomers labels Apr 4, 2023
@a-lukasiewicz
Copy link

Hi, I would like to contribute and resolve this issue. Could it be assigned to me?

@gioboa
Copy link
Contributor

gioboa commented Apr 4, 2023

@a-lukasiewicz yep, sure. Thanks

a-lukasiewicz added a commit to a-lukasiewicz/qwik-ui that referenced this issue Apr 4, 2023
@a-lukasiewicz
fix(select component): fixed select body position, show select compon…
1963f71 
…ent properly

fix qwikifiers#265
@a-lukasiewicz a-lukasiewicz mentioned this issue Apr 4, 2023
Closed
7 tasks
@a-lukasiewicz
Copy link

a-lukasiewicz commented Apr 4, 2023 •
edited
Loading

@gioboa Ready to be checked

@tleperou
Copy link
Contributor Author

@a-lukasiewicz , @gioboa ; could floating-ui struggle to play nicely with qwik ui 🤔 . Looks like there's something to do in order to ensure that floating-ui operates its magic when the chunks (cf. the components) are actually resolved.

@a-lukasiewicz
Copy link

a-lukasiewicz commented Apr 12, 2023 •
edited
Loading

@tleperou @gioboa Oh right, for this pr I made that on simple css styling - relative and absolute position. But there are more cases other than fixing that?

If the select is at the bottom of the page, the options need to appear on top.

I will take a look on that floating-ui positioning and try to fix that

a-lukasiewicz added a commit to a-lukasiewicz/qwik-ui that referenced this issue Apr 18, 2023
@a-lukasiewicz
fix(select component): fixed select behaviour to implement floating-ui
c73559d 
fix qwikifiers#265
shiroinegai added a commit to shiroinegai/qwik-ui that referenced this issue May 6, 2023
@shiroinegai
refactor(select): change naming convention
0bd7039 
Also fix qwikifiers#265, a regression caused with useTask$

re qwikifiers#300 fix qwikifiers#265
shiroinegai added a commit to shiroinegai/qwik-ui that referenced this issue May 6, 2023
@shiroinegai
refactor(select): change naming convention
6f273d5 
Also fixes qwikifiers#265, a regression caused with useTask$

re qwikifiers#300, fix qwikifiers#265
@shiroinegai shiroinegai mentioned this issue May 6, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@a-lukasiewicz a-lukasiewicz

Labels
COMMUNITY: good first issue Good for newcomers TYPE: bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@tleperou @gioboa @a-lukasiewicz