temporary-fix(big bundle & cannot-resolve-symbol): revert to non-optimized bundling until it's fixed in qwik #521
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR: I think it would be best to keep the unoptimized bundle until a real fix can be made in the optimizer or until we're ready for v1 if the optimizer issue hasn't been fixed by then.
What is it?
Description
I removed
from the headless-kit's vite config, because it creates the namespace issues described in #519, for which there is no great workaround in terms of DX.
This brings back the big bundle issue, but the "big bundle" isn't so big on first load anyway, and subsequent requests will be loaded from the browser cache.
To make the bundle smaller, I removed country-list-json and libphonenumber-js dependencies and all related code (which didn't receive any attention for the past 6 months). We can always add it back later or create another package for those kinds of components if the bug hasn't been fixed by then.
Performance should be okay now (11kb on first load 👇)
Checklist: