Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Link to supported XEPs in wiki #172

Closed
wants to merge 1 commit into from

Conversation

lnjX
Copy link
Member

@lnjX lnjX commented Jan 2, 2019

No description provided.

@codecov
Copy link

codecov bot commented Jan 2, 2019

Codecov Report

Merging #172 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #172   +/-   ##
=======================================
  Coverage   62.82%   62.82%           
=======================================
  Files         157      157           
  Lines       14944    14944           
=======================================
  Hits         9388     9388           
  Misses       5556     5556

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d838fb...91c5707. Read the comment docs.

@jlaine
Copy link
Contributor

jlaine commented Jan 2, 2019

While I'm not absolutely opposed to this, this seem to duplicate the information from:

https://github.com/qxmpp-project/qxmpp/blob/master/doc/xep.doc

Why do we prefer the wiki?

@lnjX
Copy link
Member Author

lnjX commented Jan 3, 2019

Oh, I actually wasn't aware of that list, because there's no link to. Then I'd prefer the page in the documentation. Only problems I see: afaik we can't directly link to the html version of the page from the README, because the QXmpp version number is in the URL, currently the page is outdated and it's always from the latest stable release (we could solve that by doing frequent releases :D).

@jlaine
Copy link
Contributor

jlaine commented Jan 3, 2019

OK, could you replace this PR by a PR which updates doc/xep.doc for a start? In the future we need to make sure PRs which add support for additional XEPs include the relevant change to doc/xep.doc

@jlaine jlaine closed this Jan 3, 2019
@lnjX lnjX deleted the patch-1 branch September 27, 2019 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants