WIP - Resize Bilinear AVX512 Trial #128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes optimization of - PLN load - PKD store
r-abishek
reviewed
Jun 1, 2023
src/include/cpu/rpp_cpu_simd.hpp
Outdated
| { | ||
| __m512 px[5]; | ||
| __m512i shuffle = _mm512_set_epi32(15,11,7,3,14,10,6,2,13,9,5,1,12,8,4,0); | ||
| __m512i index = _mm512_set_epi32(15,11,7,3,14,13,12,10,9,8,6,5,4,2,1,0); |
src/include/cpu/rpp_cpu_simd.hpp
Outdated
| __m512i index = _mm512_set_epi32(15,11,7,3,14,13,12,10,9,8,6,5,4,2,1,0); | ||
| p[0] = _mm512_permutexvar_ps(shuffle, p[0]); | ||
| p[1] = _mm512_permutexvar_ps(shuffle, p[1]); | ||
| p[2] = _mm512_permutexvar_ps(shuffle, p[2]); |
There was a problem hiding this comment.
Lets increase readability a bit here with - end of line comments like in many other SSE/AVX helpers, and using better variable names than shuffle and index for any reader to understand what shuffle and index are. (arrangements in pln3 or pkd3)
There was a problem hiding this comment.
Yeah added these for few newly added routines.
src/include/cpu/rpp_cpu_simd.hpp
Outdated
| __m512i indices1 = _mm512_set_epi32(loc[15],loc[14],loc[13],loc[12],loc[11],loc[10],loc[9],loc[8], | ||
| loc[7],loc[6],loc[5],loc[4],loc[3],loc[2],loc[1],loc[0]); | ||
| p[0] = _mm512_i32gather_ps(indices1, srcRowPtrsForInterp[0], sizeof(int32_t)); | ||
| __m512i indices2 = _mm512_set_epi32(loc[15]+1,loc[14]+1,loc[13]+1,loc[12]+1,loc[11]+1,loc[10]+1,loc[9]+1,loc[8]+1, |
There was a problem hiding this comment.
spaces before and after operataors
| loc[7]+1,loc[6]+1,loc[5]+1,loc[4]+1,loc[3]+1,loc[2]+1,loc[1]+1,loc[0]+1); | ||
| p[1] = _mm512_i32gather_ps(indices2, srcRowPtrsForInterp[0], sizeof(int32_t)); | ||
| p[2] = _mm512_i32gather_ps(indices1, srcRowPtrsForInterp[1], sizeof(int32_t)); | ||
| p[3] = _mm512_i32gather_ps(indices2, srcRowPtrsForInterp[1], sizeof(int32_t)); |
There was a problem hiding this comment.
Do we really need these gathers? they are pretty expensive
There was a problem hiding this comment.
Gathers are expensive but overall gave slight improvements when compared with load, transpose and insert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes AVX512 optimizations for u8 datatype for all layout variants.
Doesn't include new testsuite change.