Bitwise AND Tensor #218
Closed
Bitwise AND Tensor #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also includes fixing f16 and f32 datatype of HOST
r-abishek
reviewed
Jan 18, 2024
| rpp_hip_math_multiply8_const(src1_f8, src1_f8, (float4)255); | ||
| rpp_hip_math_multiply8_const(src2_f8, src2_f8, (float4)255); | ||
| dst_f8->f1[0] = (float)((uchar)(src1_f8->f1[0]) & (uchar)(src2_f8->f1[0])); | ||
| dst_f8->f1[1] = (float)((uchar)(src1_f8->f1[1]) & (uchar)(src2_f8->f1[1])); |
There was a problem hiding this comment.
Please verify with OpenVX, OpenCV and previous RPP if floats are being converted to uchars like here
There was a problem hiding this comment.
Found this link wherein they convert floats to integers before bitwise operation
https://stackoverflow.com/questions/1723575/how-to-perform-a-bitwise-operation-on-floating-point-numbers
Usually bitwise operations are performed on integers or char datatypes and not directly on float.
I have also checked to see if anyone in our team have used bitwise operations with float value in trainings and didn't find any such case so far.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.