Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test suite support for doing QA w.r.t performance #221

Merged
merged 10 commits into from
Jan 29, 2024
Merged

Test suite support for doing QA w.r.t performance #221

merged 10 commits into from
Jan 29, 2024

Conversation

sampath1117
Copy link
Collaborator

  • Added initial support in HOST backend

@r-abishek r-abishek added the enhancement New feature or request label Jan 23, 2024
r-abishek
r-abishek reviewed Jan 23, 2024
View reviewed changes
Copy link
Owner

@r-abishek r-abishek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the PR ensure that we can run BatchPD tests from the new test_suite? Are we adding equivalent changes for HIP?

r-abishek
r-abishek reviewed Jan 23, 2024
View reviewed changes
utilities/test_suite/HOST/runTests.py Outdated
functions = []
functionsBatchPD = []
funcCount = 0
thresholdDict = {"resize": 15, "color_twist": 15, "phase": 30}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did we decide these numbers?

@r-abishek r-abishek changed the base branch from master to develop January 29, 2024 22:47
r-abishek
r-abishek approved these changes Jan 29, 2024
View reviewed changes
Copy link
Owner

@r-abishek r-abishek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To check - Building BatchPD in cwd as per cmake changes might be counter-intuitive.

@r-abishek r-abishek changed the base branch from develop to ar/test_suite_upgrade_5_qa_perf January 29, 2024 23:08
@r-abishek r-abishek merged commit b9c8cdc into r-abishek:ar/test_suite_upgrade_5_qa_perf Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-abishek r-abishek r-abishek approved these changes

Assignees

@sampath1117 sampath1117

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sampath1117 @r-abishek @HazarathKumarM @snehaa8