Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

two minor vignette typos, in one sentence #124

Merged
merged 1 commit into from
Aug 1, 2016
Merged

two minor vignette typos, in one sentence #124

merged 1 commit into from
Aug 1, 2016

Conversation

mdsumner
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Jul 24, 2016

Current coverage is 43.80% (diff: 100%)

Merging #124 into master will not change coverage

@@             master       #124   diff @@
==========================================
  Files            16         16          
  Lines           436        436          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            191        191          
  Misses          245        245          
  Partials          0          0          

Powered by Codecov. Last update 9202aa5...844a418

@krlmlr krlmlr merged commit d29a823 into r-dbi:master Aug 1, 2016
@krlmlr
Copy link
Member

krlmlr commented Aug 1, 2016

Thanks!

krlmlr pushed a commit that referenced this pull request Aug 1, 2016
- Clean up documentation.
    - Direct S4 documentation to a hidden page to unclutter documentation index (#59).
    - Export `dbFetch()` and `dbQuoteString()` methods.
    - Add package documentation.
    - Remove full stop from documentation titles.
    - Minor documentation fixes.
- Fix two minor vignette typos (#124, @mdsumner).
krlmlr added a commit that referenced this pull request Aug 11, 2016
- Interface changes
    - `dbDataType()` maps `character` values to `"TEXT"` by default (#102).
    - The default implementation of `dbQuoteString()` doesn't call `encodeString()` anymore: Neither SQLite nor Postgres understand e.g. `\n` in a string literal, and all of SQLite, Postgres, and MySQL accept an embedded newline (#121).

- Interface enhancements
    - New `dbSendStatement()` generic, forwards to `dbSendQuery()` by default (#20, #132).
    - New `dbExecute()`, calls `dbSendStatement()` by default (#109, @bborgesr).
    - New `dbWithTransaction()` that calls `dbBegin()` and `dbCommit()`, and `dbRollback()` on failure (#110, @bborgesr).
    - New `dbBreak()` function which allows aborting from within `dbWithTransaction()` (#115, #133).
    - Export `dbFetch()` and `dbQuoteString()` methods.

- Documentation improvements:
    - One example per function (except functions scheduled for deprecation) (#67).
    - Consistent layout and identifier naming.
    - Better documentation of generics by adding links to the class and related generics in the "See also" section under "Other DBI... generics" (#130). S4 documentation is directed to a hidden page to unclutter documentation index (#59).
    - Fix two minor vignette typos (#124, @mdsumner).
    - Add package documentation.
    - Remove misleading parts in `dbConnect()` documentation (#118).
    - Remove misleading link in `dbDataType()` documentation.
    - Remove full stop from documentation titles.
    - New help topic "DBIspec" that contains the full DBI specification (currently work in progress) (#129).
    - HTML documentation generated by `staticdocs` is now uploaded to http://rstats-db.github.io/DBI for each build of the "production" branch (#131).
    - Further minor changes and fixes.

- Internal
    - Use `contains` argument instead of `representation()` to denote base classes (#93).
    - Remove redundant declaration of transaction methods (#110, @bborgesr).
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants