Fix compilation on Alpine Linux #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Pass down CXXFLAGS to libcctz. On https://github.com/r-hub/r-minimal we set __MUSL__. This is not a standard, but nevertheless some R packages (e.g. Rcpp) rely on it already, and at least the user can set it in a user Makevars file. * Use __MUSL__ to select the right strerror_r signature. I don't know why this is not happening automatically. It might be a libcctz bug or a musl bug.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CXXFLAGSto libcctz. On https://github.com/r-hub/r-minimalwe set
__MUSL__. This is not a standard, but nevertheless someR packages (e.g. Rcpp) rely on it already, and at least the user
can set it in a user Makevars file.
__MUSL__to select the rightstrerror_rsignature. I don't knowwhy this is not happening automatically. It might be a libcctz
bug or a musl bug.