Adds Hive subclass and dbQuoteString method for it #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hive uses C-style escape for string literals, so a single-quote inside a string literal should be replaced with `\'` and not `''` (as is currently the case). See #184 for details.
Hive subclass with dbQuoteString, odbcListColumns methods
`setMethod("dbQuoteString", "Hive", ...)` ends up still dispatching to `DBI:::quote_string` - you need to specify the signature for both `con` and `x`.
will never dispatch to this method if `x` is not of class `character`, so no need for that check
so I backslash-escaped the backslash-escaped backslash
`DBI::SQL(paste0("'", gsub("'", "\\\\'", "it's"), "'"))` returns `<SQL> 'it\'s'`, which is what we want
|
It looks like you are missing documentation for the new methods, which is why the checks are failing. e.g. https://github.com/r-dbi/odbc/pull/424/checks?check_run_id=1619012948#step:10:74 |
|
/document |
jimhester
approved these changes
Feb 25, 2021
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hive uses C-style escape for string literals, so a single-quote inside a string literal should be replaced with
\'and not''(as is currently the case). See #184 for details.