-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GHA for linting only the changes files #620
Add GHA for linting only the changes files #620
Conversation
Codecov Report
@@ Coverage Diff @@
## v2-branch #620 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 2 2
Lines 10 10
===========================================
Hits 10 10 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
with: | ||
extra-packages: | | ||
any::gh | ||
any::lintr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally prefer using r-lib/lintr
here to get the latest and the best version of {lintr}
, but not sure if others agree with that choice. So, using CRAN {lintr}
.
Looks fine to me :) |
@gaborcsardi Let me know if you need me to make any other changes here. Thanks. |
Thanks! I am going to merge this now, but in the future we might move it to a different directory or repository, together with other "contributed" workflow examples, to make it clear that this does not have level of testing and support. |
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this pull request. |
Closes #567
Changes from current version in
{lintr}
:{lintr}
once GHA workflowlint-changed-files
fails when a new lint is found in changed files lintr#1522 is merged)..lintr
file to find lintr settings instead of.lintr_new
, which is something{lintr}
-specific.cc @MichaelChirico Do you see anything else that should be modified for general usage?