Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GHA for linting only the changes files #620

Merged
merged 3 commits into from
Oct 19, 2022
Merged

Add GHA for linting only the changes files #620

merged 3 commits into from
Oct 19, 2022

Conversation

IndrajeetPatil
Copy link
Contributor

Closes #567

Changes from current version in {lintr}:

cc @MichaelChirico Do you see anything else that should be modified for general usage?

@codecov-commenter
Copy link

Codecov Report

Merging #620 (6f32ec2) into v2-branch (7dbac86) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           v2-branch      #620   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
===========================================
  Files              2         2           
  Lines             10        10           
===========================================
  Hits              10        10           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

with:
extra-packages: |
any::gh
any::lintr
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally prefer using r-lib/lintr here to get the latest and the best version of {lintr}, but not sure if others agree with that choice. So, using CRAN {lintr}.

@MichaelChirico
Copy link

Looks fine to me :)

@IndrajeetPatil
Copy link
Contributor Author

@gaborcsardi Let me know if you need me to make any other changes here. Thanks.

@gaborcsardi
Copy link
Member

Thanks! I am going to merge this now, but in the future we might move it to a different directory or repository, together with other "contributed" workflow examples, to make it clear that this does not have level of testing and support.

@gaborcsardi gaborcsardi merged commit fe719f6 into r-lib:v2-branch Oct 19, 2022
@IndrajeetPatil IndrajeetPatil deleted the 567_add_lint_changed_files_gha branch October 19, 2022 11:54
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "lint changed files" action
4 participants